Skip to content
This repository was archived by the owner on Oct 22, 2024. It is now read-only.

Conversation

@dbkr
Copy link
Member

@dbkr dbkr commented Sep 18, 2024

Because apparently secrets: inherit only works for environment secrets, and it only took me several hours of research to track this down 🙄

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Because apparently secrets: inherit only works for environment secrets, and it only took me several hours of research to track this down 🙄
@dbkr dbkr added the T-Task Tasks for the team like planning label Sep 18, 2024
@dbkr dbkr marked this pull request as ready for review September 18, 2024 15:21
@dbkr dbkr requested a review from a team as a code owner September 18, 2024 15:21
@dbkr dbkr requested a review from florianduros September 18, 2024 15:21
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because apparently secrets: inherit only works for environment secrets, and it only took me several hours of research to track this down 🙄

This isn't the case, but secrets inherit only works in the same org as per the docs https://docs.github.com/en/actions/sharing-automations/reusing-workflows#:~:text=Pass%20the%20input%20or%20secret%20from%20the%20caller%20workflow.

@dbkr dbkr added this pull request to the merge queue Sep 18, 2024
Merged via the queue into develop with commit 0bbed85 Sep 18, 2024
32 checks passed
@dbkr dbkr deleted the dbkr-explicit-secrets branch September 18, 2024 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Tasks for the team like planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants