Skip to content

Android: allow passing a Jsoup Document to html converter#91

Merged
jmartinesp merged 2 commits intomainfrom
msic/android-allow-passing-dom-in-to-spans-converter
Dec 3, 2025
Merged

Android: allow passing a Jsoup Document to html converter#91
jmartinesp merged 2 commits intomainfrom
msic/android-allow-passing-dom-in-to-spans-converter

Conversation

@jmartinesp
Copy link
Member

This allows us to parse the HTML contents just once if we need to keep the Document in the client too (as we need for EXA).

Also, centralise, extract and make public the HTML to Document parser.
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.94%. Comparing base (da86958) to head (7e1c0ac).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   89.17%   87.94%   -1.24%     
==========================================
  Files         169       94      -75     
  Lines       19666    15434    -4232     
  Branches      296      296              
==========================================
- Hits        17538    13573    -3965     
+ Misses       2125     1858     -267     
  Partials        3        3              
Flag Coverage Δ
uitests ?
uitests-ios ?
unittests 87.94% <ø> (+0.07%) ⬆️
unittests-ios ?
unittests-react 83.37% <ø> (ø)
unittests-rust 88.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@jmartinesp jmartinesp requested review from bmarty and ganfra December 3, 2025 08:55
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jmartinesp jmartinesp merged commit 837c922 into main Dec 3, 2025
9 checks passed
@jmartinesp jmartinesp deleted the msic/android-allow-passing-dom-in-to-spans-converter branch December 3, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants