Push Sygnal docker images to Element OCI Registry#428
Draft
Conversation
Member
Author
|
I manually kicked off the workflow to test but it is failing: https://github.com/element-hq/sygnal/actions/runs/21531325167/job/62047676876 This shouldn't be merged until that is passing. |
Member
Author
Comment on lines
+61
to
+64
| - name: Compute vault jwt role name | ||
| id: vault-jwt-role | ||
| run: | | ||
| echo "role_name=github_service_management_$( echo "${{ github.repository }}" | sed -r 's|[/-]|_|g')" | tee -a "$GITHUB_OUTPUT" |
Member
There was a problem hiding this comment.
I'm confused - we're pulling out credentials from Vault for the docker.io/matrixdotorg/sygnal repository as well?
It feels like this should just be one job which:
- Sets up docker
- Sources the registry token from Ansible vault
- (Decides whether to tag latest)
- Builds the image
- Publishes it to both registries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/element-hq/serverproduct-internal/issues/1153
Pushes Sygnal docker images to the Element OCI Registry in addition to the dockerhub registry.
Ready for review despite Draft status. See #428 (comment)