Skip to content

Conversation

@MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Jul 11, 2025

Remove allow_no_prev_events option. This option is no longer used since we backed out the MSC2716 changes in matrix-org/synapse#15748 and is even mentioned as a follow-up task in the PR description there.

The allow_no_prev_events option was first introduced in matrix-org/synapse#11243 to support MSC2716 back in the day.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@MadLittleMods MadLittleMods changed the title Remove allow_no_prev_events option Remove allow_no_prev_events option (MSC2716 cleanup) Jul 11, 2025
@MadLittleMods MadLittleMods force-pushed the madlittlemods/remove-allow_no_prev_events branch from 71e9669 to 85a9149 Compare July 11, 2025 21:28
@MadLittleMods MadLittleMods marked this pull request as ready for review July 11, 2025 22:03
@MadLittleMods MadLittleMods requested a review from a team as a code owner July 11, 2025 22:03
@MadLittleMods MadLittleMods merged commit d72c278 into develop Jul 15, 2025
43 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/remove-allow_no_prev_events branch July 15, 2025 20:53
@MadLittleMods
Copy link
Contributor Author

Thanks for the review @reivilibre 🦇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants