Fix deactivation running off the main process #18716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the part that can't be handled by workers through replication
|
This has been deployed to Matrix.org and works as expected |
MadLittleMods
approved these changes
Jul 23, 2025
Co-authored-by: Eric Eastwood <[email protected]>
benbz
added a commit
to element-hq/ess-helm
that referenced
this pull request
Aug 1, 2025
benbz
added a commit
to element-hq/ess-helm
that referenced
this pull request
Aug 1, 2025
benbz
added a commit
to element-hq/ess-helm
that referenced
this pull request
Aug 1, 2025
benbz
added a commit
to element-hq/ess-helm
that referenced
this pull request
Aug 1, 2025
benbz
added a commit
to element-hq/ess-helm
that referenced
this pull request
Aug 1, 2025
benbz
added a commit
to element-hq/ess-helm
that referenced
this pull request
Aug 1, 2025
benbz
added a commit
to element-hq/ess-helm
that referenced
this pull request
Aug 1, 2025
benbz
added a commit
to element-hq/ess-helm
that referenced
this pull request
Aug 1, 2025
benbz
added a commit
to element-hq/ess-helm
that referenced
this pull request
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit by commit.
With the new dedicated MAS API (#18520), it's possible that deactivation starts off the main process, which was not possible because of a few calls.
I basically looked at everything that the deactivation handler was doing, reviewed whether it could run on workers or not, and find a workaround when possible