Skip to content

Conversation

AndrewFerr
Copy link
Member

@AndrewFerr AndrewFerr commented Oct 13, 2025

Can do this now that SQLite 3.40 supports RETURNING.

This also bumps the minimum suppoted SQLite version according to Synapse's deprecation policy.

Addresses #17577

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@AndrewFerr AndrewFerr requested a review from a team as a code owner October 13, 2025 02:34
@github-actions github-actions bot deployed to PR Documentation Preview October 13, 2025 02:35 Active
@github-actions github-actions bot deployed to PR Documentation Preview October 13, 2025 02:59 Active
@reivilibre
Copy link
Contributor

seems good, CI is failing though (maybe a missed usage of supports_returning?)

@github-actions github-actions bot deployed to PR Documentation Preview October 14, 2025 03:52 Active
as bookworm is what bumped libsqlite
@github-actions github-actions bot deployed to PR Documentation Preview October 15, 2025 21:58 Active
Comment on lines +78 to +79
if sqlite3.sqlite_version_info < (3, 40, 0):
raise RuntimeError("Synapse requires sqlite 3.40 or above.")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs the Sytest image to install SQLite >=3.40.

See: matrix-org/sytest#1414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants