Skip to content

Conversation

@turt2live
Copy link
Member

@turt2live turt2live commented Dec 2, 2025

Note: this was written using the copy/paste development technique, so may not adhere to great Python standards.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@turt2live
Copy link
Member Author

looks like test flakes on not-my changes

@turt2live turt2live marked this pull request as ready for review December 2, 2025 21:44
@turt2live turt2live requested a review from a team as a code owner December 2, 2025 21:44
@anoadragon453
Copy link
Member

The trial and Build release artifacts CI failures look related to your changes, I'm afraid (typically it's only the Complement or Sytest runs that will flake):

[FAIL]
Traceback (most recent call last):
  File "/tmp/tmp.mV4uD1eGTx/tests/rest/admin/test_media.py", line 833, in test_list_quarantined_media
    self.assertEqual(200, channel.code, msg=channel.json_body)
  File "/synapse/build/debian/matrix-synapse-py3/opt/venvs/matrix-synapse/lib/python3.13/site-packages/twisted/trial/_synctest.py", line 444, in assertEqual
    super().assertEqual(first, second, msg)
  File "/usr/lib/python3.13/unittest/case.py", line 907, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python3.13/unittest/case.py", line 900, in _baseAssertEqual
    raise self.failureException(msg)
twisted.trial.unittest.FailTest: 200 != 401 : {'errcode': 'M_MISSING_TOKEN', 'error': 'Missing access token'}

tests.rest.admin.test_media.ListQuarantinedMediaTestCase.test_list_quarantined_media

and looks due to this line not having an access token specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants