Skip to content

Update README#787

Closed
NoyaOffer wants to merge 1 commit intomasterfrom
readme_changes
Closed

Update README#787
NoyaOffer wants to merge 1 commit intomasterfrom
readme_changes

Conversation

@NoyaOffer
Copy link
Contributor

Updating README with changes wrote with Roni :)

Updating README with changes wrote with Roni
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

👋 @NoyaOffer
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

Comment on lines +26 to +32
- What's Inside the Elementary dbt Package?
- Quick start - dbt package
- Get more out of Elementary dbt package
- Metadata tables - Run Results and dbt artifacts
- Data anomaly detection as dbt tests
- [Community & Support](https://www.notion.so/dbt-README-1ab621a084bf8027ac32e8b6f663a231?pvs=21)
- [Contribution](https://www.notion.so/dbt-README-1ab621a084bf8027ac32e8b6f663a231?pvs=21)
Copy link
Contributor

@MikaKerman MikaKerman Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We previously had links to the relevant sections, and now we only have links for the "Community" and "Contribution" sections.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in readme_changes-1

- [Contribution](#contributions)
✅ [**Elementary Open Source**](https://docs.elementary-data.com/oss/oss-introduction) – A powerful, self-hosted tool for teams that want full control.

✅ [**Elementary Cloud Platform**](https://docs.elementary-data.com/cloud/introduction) – A fully managed, enterprise-ready solution with **ML-powered anomaly detection, flexible data discovery, integrated incident management, and collaboration tools**—all with minimal setup and infrastructure maintenance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add automated? WDYT?

Suggested change
✅ [**Elementary Cloud Platform**](https://docs.elementary-data.com/cloud/introduction) – A fully managed, enterprise-ready solution with **ML-powered anomaly detection, flexible data discovery, integrated incident management, and collaboration tools**—all with minimal setup and infrastructure maintenance.
✅ [**Elementary Cloud Platform**](https://docs.elementary-data.com/cloud/introduction) – A fully managed, enterprise-ready solution with **automated ML-powered anomaly detection, flexible data discovery, integrated incident management, and collaboration tools**—all with minimal setup and infrastructure maintenance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in readme_changes-1

Comment on lines +53 to +54
1. Run `dbt deps`
2. Add to your `dbt_project.yml`:
Copy link
Contributor

@MikaKerman MikaKerman Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the numbers

Suggested change
1. Run `dbt deps`
2. Add to your `dbt_project.yml`:
2. Run `dbt deps`
3. Add to your `dbt_project.yml`:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in readme_changes-1

```

4. Run `dbt run --select elementary`
1. Run `dbt run --select elementary`
Copy link
Contributor

@MikaKerman MikaKerman Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

Suggested change
1. Run `dbt run --select elementary`
4. Run `dbt run --select elementary`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in readme_changes-1

Comment on lines +102 to +107
- **dbt_models** – Details on all dbt models.
- **dbt_tests** – Stores information about dbt tests.
- **dbt_sources** – Tracks source tables and freshness checks.
- **dbt_exposures** – Logs downstream data usage.
- **dbt_metrics** – Captures dbt-defined metrics.
- **dbt_snapshots** – Stores historical snapshot data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presenting these tables before the Run Results Tables could be more logical, as all the tables there are connected to objects in one of the dbt_X tables.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in readme_changes-1


**Elementary tests are configured and executed like native tests in your project!**

Elementary dbt tests track key metrics and metadata over time, including freshness, volume, schema changes, distribution, cardinality, and more.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema changes are not related to anomaly detections.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NoyaOffer What do you think?

@@ -106,19 +127,10 @@ models:
tests:
- elementary.table_anomalies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table_anomalies?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in readme_changes-1

<kbd align="center">
<a href="https://storage.googleapis.com/elementary_static/elementary_demo.html"><img align="center" style="max-width:300px;" src="https://raw.githubusercontent.com/elementary-data/elementary/master/static/report_ui.gif"> </a>
</kbd>
Read more about the available [Elementary tests and configuration](https://docs.elementary-data.com/data-tests/introduction).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are your thoughts on including the test list here before directing users to another site to view the tests? It would be similar to how we showcase the table artifacts list before guiding them to our site for more information. This package's core functionality lies in this feature!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in readme_changes-1

<kbd align="center">
<a href="https://storage.googleapis.com/elementary_static/elementary_demo.html"><img align="center" style="max-width:300px;" src="https://raw.githubusercontent.com/elementary-data/elementary/master/static/report_ui.gif"> </a>
</kbd>
Read more about the available [Elementary tests and configuration](https://docs.elementary-data.com/data-tests/introduction).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding:
Check out the contributions guide

It redirects to "Welcome to Elementary"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in readme_changes-1

- An open-source CLI tool you can deploy and orchestrate to send alerts and self-host the Elementary report. Best for data and analytics engineers that require basic observability capabilities or for evaluating features without vendor approval. Our community can provide great support on [Slack](https://www.elementary-data.com/community) if needed.
To generate observability reports, send alerts, and govern your data quality effectively, connect your dbt package to one of the following options:

- **Elementary OSS**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a link here to the Python package OSS.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NoyaOffer What do you think? a link to the repo?

@NoyaOffer NoyaOffer closed this Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants