Skip to content

feat: Add resource type option to generate_schema_baseline_test #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oravi merged 1 commit into from
Mar 20, 2025
+7 −8
Merged

feat: Add resource type option to generate_schema_baseline_test #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions macros/commands/generate_schema_baseline_test.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{% macro generate_schema_baseline_test(name=none, include_sources=True, include_models=False, fail_on_added=False, enforce_types=False, convert_to_lower=False) %}
{% macro generate_schema_baseline_test(name=none, include_sources=True, include_models=False, fail_on_added=False, enforce_types=False, convert_to_lower=False, resource_type=none) %}
{% if name %}
{{ generate_schema_baseline_test_for_node(name, fail_on_added=fail_on_added, enforce_types=enforce_types, convert_to_lower=convert_to_lower) }}
{{ generate_schema_baseline_test_for_node(name, fail_on_added=fail_on_added, enforce_types=enforce_types, convert_to_lower=convert_to_lower, resource_type=resource_type) }}
{% else %}
{{ generate_schema_baseline_test_for_all_nodes(include_sources=include_sources, include_models=include_models,
fail_on_added=fail_on_added, enforce_types=enforce_types, convert_to_lower=convert_to_lower) }}
Expand All @@ -20,11 +20,10 @@
{% endfor %}
{% endmacro %}

{% macro generate_schema_baseline_test_for_node(node, fail_on_added=False, enforce_types=False, convert_to_lower=False) %}
{% macro generate_schema_baseline_test_for_node(node, fail_on_added=False, enforce_types=False, convert_to_lower=False, resource_type=none) %}
{% if node is string %}
{% set node_name = node %}
{% set node = elementary.get_node_by_name(node_name) %}

{% set node = elementary.get_node_by_name(node_name, resource_type) %}
{% if not node %}
{% do print("Could not find any model or source by the name '{}'!".format(node_name)) %}
{% do return(none) %}
Expand Down Expand Up @@ -84,7 +83,7 @@ sources:
{%- for param, param_val in test_params.items() %}
{{param}}: {{param_val}}
{%- endfor -%}
{% endif -%}
{% endif -%}
{% endmacro %}

{% macro generate_schema_baseline_test_for_model(node, columns, test_params, convert_to_lower) %}
Expand Down
4 changes: 2 additions & 2 deletions macros/utils/graph/get_node_by_name.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% macro get_node_by_name(name) %}
{% macro get_node_by_name(name, resource_type=none) %}
{%- set nodes = elementary.get_nodes_from_graph() -%}
{% for node in nodes %}
{% if node.name == name %}
{% if node.name == name and (resource_type is none or node.resource_type == resource_type) %}
{% do return(node) %}
{% endif %}
{% endfor %}
Expand Down
Loading