-
Notifications
You must be signed in to change notification settings - Fork 121
CI - restrict postgres version #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 @haritamar |
WalkthroughThe Postgres service image in the Docker Compose configuration has been updated from an unversioned reference to an explicitly pinned version tag (postgres:15), ensuring consistent deployments across environments. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
integration_tests/docker-compose.yml (1)
5-5: Consider pinning versions for other services as well.While the Postgres service now has an explicit version tag, ClickHouse (line 16) and pgAdmin (line 33) still use unversioned references (
latestand implicitly latest, respectively). This could introduce the same CI flakiness for those services if they release breaking changes. Depending on your stability requirements, consider pinning their versions too—or document why Postgres requires pinning but others don't.Also applies to: 16-16, 33-33
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
integration_tests/docker-compose.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
- GitHub Check: test (fusion, redshift) / test
- GitHub Check: test (latest_official, athena) / test
- GitHub Check: test (fusion, bigquery) / test
- GitHub Check: test (fusion, snowflake) / test
- GitHub Check: test (latest_pre, postgres) / test
- GitHub Check: test (latest_official, databricks_catalog) / test
- GitHub Check: test (latest_official, trino) / test
- GitHub Check: test (latest_official, clickhouse) / test
- GitHub Check: test (latest_official, snowflake) / test
- GitHub Check: test (fusion, databricks_catalog) / test
- GitHub Check: test (latest_official, bigquery) / test
- GitHub Check: test (latest_official, dremio) / test
- GitHub Check: test (latest_official, redshift) / test
- GitHub Check: test (latest_official, postgres) / test
🔇 Additional comments (1)
integration_tests/docker-compose.yml (1)
5-5: Good catch pinning the Postgres version for CI stability.Pinning to
postgres:15ensures reproducible test runs across environments and prevents unexpected breakage from upstream version changes. This is a best practice for CI infrastructure.
Summary by CodeRabbit