Skip to content

made the description of the anomaly test more accurate #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuyEshdat merged 2 commits into from
Nov 9, 2025
Merged

made the description of the anomaly test more accurate #883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac34be5
made the description of the anomaly test more accurate
GuyEshdat Nov 9, 2025
44f3504
made the description of the anomaly test more accurate
GuyEshdat Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion macros/edr/alerts/anomaly_detection_description.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
{% endmacro %}

{% macro freshness_description() %}
'Last update was at ' || anomalous_value || ', ' || {{ elementary.edr_cast_as_string('abs(round(' ~ elementary.edr_cast_as_numeric('metric_value/3600') ~ ', 2))') }} || ' hours ago. Usually the table is updated within ' || {{ elementary.edr_cast_as_string('abs(round(' ~ elementary.edr_cast_as_numeric('training_avg/3600') ~ ', 2))') }} || ' hours.'
'Last update was at ' || anomalous_value || ', ' || 'which is' || {{ elementary.edr_cast_as_string('abs(round(' ~ elementary.edr_cast_as_numeric('metric_value/3600') ~ ', 2))') }} || ' hours without updates (only full buckets are considered). Usually the table is updated within ' || {{ elementary.edr_cast_as_string('abs(round(' ~ elementary.edr_cast_as_numeric('training_avg/3600') ~ ', 2))') }} || ' hours.'
Copy link

@coderabbitai coderabbitai bot Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add space between "which is" and the numeric value.

The string concatenation is missing a space between 'which is' and the calculated metric value. This will produce user-facing output like "which is2.5 hours" instead of "which is 2.5 hours".

Apply this diff to fix the spacing:

-    'Last update was at ' || anomalous_value || ', ' || 'which is' || {{ elementary.edr_cast_as_string('abs(round(' ~ elementary.edr_cast_as_numeric('metric_value/3600') ~ ', 2))') }} || ' hours without updates (only full buckets are considered). Usually the table is updated within ' || {{ elementary.edr_cast_as_string('abs(round(' ~ elementary.edr_cast_as_numeric('training_avg/3600') ~ ', 2))') }} || ' hours.'
+    'Last update was at ' || anomalous_value || ', ' || 'which is ' || {{ elementary.edr_cast_as_string('abs(round(' ~ elementary.edr_cast_as_numeric('metric_value/3600') ~ ', 2))') }} || ' hours without updates (only full buckets are considered). Usually the table is updated within ' || {{ elementary.edr_cast_as_string('abs(round(' ~ elementary.edr_cast_as_numeric('training_avg/3600') ~ ', 2))') }} || ' hours.'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
'Last update was at ' || anomalous_value || ', ' || 'which is' || {{ elementary.edr_cast_as_string('abs(round(' ~ elementary.edr_cast_as_numeric('metric_value/3600') ~ ', 2))') }} || ' hours without updates (only full buckets are considered). Usually the table is updated within ' || {{ elementary.edr_cast_as_string('abs(round(' ~ elementary.edr_cast_as_numeric('training_avg/3600') ~ ', 2))') }} || ' hours.'
'Last update was at ' || anomalous_value || ', ' || 'which is ' || {{ elementary.edr_cast_as_string('abs(round(' ~ elementary.edr_cast_as_numeric('metric_value/3600') ~ ', 2))') }} || ' hours without updates (only full buckets are considered). Usually the table is updated within ' || {{ elementary.edr_cast_as_string('abs(round(' ~ elementary.edr_cast_as_numeric('training_avg/3600') ~ ', 2))') }} || ' hours.'
🤖 Prompt for AI Agents 
In macros/edr/alerts/anomaly_detection_description.sql around line 13, the
string concat lacks a space after "which is", causing output like "which is2.5
hours"; fix by adding a trailing space to that literal (e.g., change 'which is'
to 'which is ') or insert an explicit ' ' || between the literal and the numeric
expression so the rendered sentence reads "which is 2.5 hours".

{% endmacro %}

{% macro table_metric_description() %}
Expand Down