-
Notifications
You must be signed in to change notification settings - Fork 204
Readme rebranded and up to date #2065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added introductory section about Elementary OSS and its features.
Updated README to include a new image format and alignment.
|
👋 @NoyaOffer |
WalkthroughREADME.md was rewritten: branding and heading updated for "Elementary OSS", local images replaced with remote assets and a demo GIF, new badges and centered blocks added, a "How It Works" section introduced, feature/support text reworded, and links/asset references updated. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
static/demoreadme.gifis excluded by!**/*.gifstatic/newreadmedemo.gifis excluded by!**/*.gif
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[grammar] ~60-~60: Use a hyphen to join words.
Context: ...s** - Validate and monitor data using AI powered tests to validate both structure...
(QB_NEW_EN_HYPHEN)
🪛 markdownlint-cli2 (0.18.1)
README.md
5-5: Images should have alternate text (alt text)
(MD045, no-alt-text)
6-6: Images should have alternate text (alt text)
(MD045, no-alt-text)
21-21: Images should have alternate text (alt text)
(MD045, no-alt-text)
48-48: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: code-quality
🔇 Additional comments (1)
README.md (1)
21-21: Asset files are present and committed.Both
static/star_github.png(11 KB) andstatic/newreadmedemo.gif(7.1 MB) are already in the repository and properly committed. No action needed.
| Follow the quickstart guide to install and configure the Elementary dbt package and CLI: | ||
|
|
||
| [Get started with the Open-source Package](https://docs.elementary-data.com/oss/oss-introduction) | ||
| 👉 https://docs.elementary-data.com/oss/quickstart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrap bare URL in markdown link syntax.
Line 48 contains a bare URL that violates markdown lint conventions. URLs should be wrapped in markdown link syntax for better formatting and consistency.
- 👉 https://docs.elementary-data.com/oss/quickstart
+ 👉 [https://docs.elementary-data.com/oss/quickstart](https://docs.elementary-data.com/oss/quickstart)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| 👉 https://docs.elementary-data.com/oss/quickstart | |
| 👉 [https://docs.elementary-data.com/oss/quickstart](https://docs.elementary-data.com/oss/quickstart) |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
48-48: Bare URL used
(MD034, no-bare-urls)
🤖 Prompt for AI Agents
In README.md around line 48, the bare URL
"https://docs.elementary-data.com/oss/quickstart" should be wrapped in markdown
link syntax; replace the raw URL with a markdown link like [Quickstart
Guide](https://docs.elementary-data.com/oss/quickstart) or an appropriately
labeled link so it conforms to markdown linting and improves readability.
| - **Alerts** - Actionable alerts including custom channels and tagging of owners. | ||
| - **Data catalog** - Explore your datasets information - descriptions, columns, datasets health, etc. | ||
| - **dbt artifacts uploader** - Save metadata and run results as part of your dbt runs. | ||
| - **AI-Powered Data Tests & Unstructured Data Validations** - Validate and monitor data using AI powered tests to validate both structured and unstructured data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hyphenate "AI-powered" for proper grammar.
The phrase "AI powered" on Line 60 should use a hyphen to join the compound modifier.
- - **AI-Powered Data Tests & Unstructured Data Validations** - Validate and monitor data using AI powered tests to validate both structured and unstructured data
+ - **AI-Powered Data Tests & Unstructured Data Validations** - Validate and monitor data using AI-powered tests to validate both structured and unstructured data📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - **AI-Powered Data Tests & Unstructured Data Validations** - Validate and monitor data using AI powered tests to validate both structured and unstructured data | |
| - **AI-Powered Data Tests & Unstructured Data Validations** - Validate and monitor data using AI-powered tests to validate both structured and unstructured data |
🧰 Tools
🪛 LanguageTool
[grammar] ~60-~60: Use a hyphen to join words.
Context: ...s** - Validate and monitor data using AI powered tests to validate both structure...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents
In README.md around line 60, the phrase "AI powered" should be hyphenated as
"AI-powered"; update the line to use "AI-powered Data Tests & Unstructured Data
Validations" (i.e., replace "AI powered" with "AI-powered") to correct the
compound modifier grammar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (4)
README.md (4)
5-6: Add alt text to badge images.These badge images are missing alt text attributes, which violates accessibility standards and markdown linting rules.
Apply this diff:
-<a href="https://join.slack.com/t/elementary-community/shared_invite/zt-uehfrq2f-zXeVTtXrjYRbdE_V6xq4Rg"><img src="https://img.shields.io/badge/join-Slack-ff69b4"/></a> -<a href="https://docs.elementary-data.com/oss/quickstart/quickstart-cli-package"><img src="https://img.shields.io/badge/docs-quickstart-orange"/></a> +<a href="https://join.slack.com/t/elementary-community/shared_invite/zt-uehfrq2f-zXeVTtXrjYRbdE_V6xq4Rg"><img src="https://img.shields.io/badge/join-Slack-ff69b4" alt="Join Slack community"/></a> +<a href="https://docs.elementary-data.com/oss/quickstart/quickstart-cli-package"><img src="https://img.shields.io/badge/docs-quickstart-orange" alt="View quickstart documentation"/></a>
21-21: Add alt text to star repository image.The image on Line 21 is missing an alt text attribute, which degrades accessibility.
Apply this diff:
- ⭐️ Star the repo <a href="https://github.com/elementary-data/elementary/stargazers"><img src="static/star_github.png" width="45"/></a> + ⭐️ Star the repo <a href="https://github.com/elementary-data/elementary/stargazers"><img src="static/star_github.png" width="45" alt="GitHub stargazers"/></a>
47-47: Wrap bare URL in markdown link syntax.Line 47 contains a bare URL, which violates markdown linting rules. URLs should be wrapped in proper markdown link syntax.
Apply this diff:
-👉 https://docs.elementary-data.com/oss/quickstart +👉 [Quickstart Guide](https://docs.elementary-data.com/oss/quickstart)
60-60: Hyphenate "AI-powered" compound modifier.The phrase "AI powered" should use a hyphen to form a proper compound modifier.
Apply this diff:
-- **AI-Powered Data Tests & Unstructured Data Validations** - Validate and monitor data using AI powered tests to validate both structured and unstructured data +- **AI-Powered Data Tests & Unstructured Data Validations** - Validate and monitor data using AI-powered tests to validate both structured and unstructured data
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[grammar] ~60-~60: Use a hyphen to join words.
Context: ...s** - Validate and monitor data using AI powered tests to validate both structure...
(QB_NEW_EN_HYPHEN)
🪛 markdownlint-cli2 (0.18.1)
README.md
5-5: Images should have alternate text (alt text)
(MD045, no-alt-text)
6-6: Images should have alternate text (alt text)
(MD045, no-alt-text)
21-21: Images should have alternate text (alt text)
(MD045, no-alt-text)
47-47: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: code-quality
| <a href="https://join.slack.com/t/elementary-community/shared_invite/zt-uehfrq2f-zXeVTtXrjYRbdE_V6xq4Rg"><img src="https://img.shields.io/badge/join-Slack-ff69b4"/></a> | ||
| <a href="https://docs.elementary-data.com/oss/quickstart/quickstart-cli-package"><img src="https://img.shields.io/badge/docs-quickstart-orange"/></a> | ||
| <img alt="License" src="https://img.shields.io/badge/license-Apache--2.0-ff69b4"/> | ||
| <img alt="Downloads" src="https://static.pepy.tech/personalized-badge/elementary-lineage?period=total&units=international_system&left_color=grey&right_color=orange"&left_text=Downloads/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix malformed HTML attribute in Downloads badge.
The src attribute is not properly closed. The URL is followed by "&left_text=Downloads/>, which breaks the tag syntax.
Apply this diff:
-<img alt="Downloads" src="https://static.pepy.tech/personalized-badge/elementary-lineage?period=total&units=international_system&left_color=grey&right_color=orange"&left_text=Downloads/>
+<img alt="Downloads" src="https://static.pepy.tech/personalized-badge/elementary-lineage?period=total&units=international_system&left_color=grey&right_color=orange&left_text=Downloads" />📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <img alt="Downloads" src="https://static.pepy.tech/personalized-badge/elementary-lineage?period=total&units=international_system&left_color=grey&right_color=orange"&left_text=Downloads/> | |
| <img alt="Downloads" src="https://static.pepy.tech/personalized-badge/elementary-lineage?period=total&units=international_system&left_color=grey&right_color=orange&left_text=Downloads" /> |
🤖 Prompt for AI Agents
In README.md around line 8, the <img> tag has a malformed src attribute because
the closing quote is placed before the &left_text parameter; move the
&left_text=Downloads fragment inside the src value and close the quote properly,
then ensure the tag is closed (e.g.,
src="...&left_color=orange&left_text=Downloads" />) so the attribute syntax and
tag are valid.
Uploaded new animation files as well
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.