Skip to content

Conversation

@JanDintel
Copy link

@JanDintel JanDintel commented Sep 10, 2024

Introduction

Support multiple platforms (architectures) for the Docker container in the Github Action release.

In this way open-source users can run the Docker image on both x86 and arm architectures. Rational behind this is because more cloud providers are supporting arm architectures with provide a better price-performance.

Closed GH-1699

Supporting documentation

@JanDintel JanDintel changed the title Setup multi-platform Docker images to support both x86 and arm architures #1699 Setup multi-platform Docker images to support both x86 and arm architures Sep 10, 2024
@JanDintel JanDintel changed the title #1699 Setup multi-platform Docker images to support both x86 and arm architures GH-1699 Setup multi-platform Docker images to support both x86 and arm architures Sep 10, 2024
@JanDintel JanDintel changed the title GH-1699 Setup multi-platform Docker images to support both x86 and arm architures GH-1699 Setup multi-platform Docker images to support both x86 and arm architectures Sep 10, 2024
@ofek1weiss ofek1weiss self-assigned this Sep 23, 2024
@ofek1weiss
Copy link
Contributor

Hey @JanDintel , looks great 🚀
make sure to update your branch with master and ill make sure it is merged 😁

@ofek1weiss
Copy link
Contributor

@JanDintel Just one thing, looks like in the empty lines you added, there are whitespaces which our code quality check does not seem to like, make sure to remove those

@JanDintel JanDintel force-pushed the multi-arch-docker-image branch from 011253e to 77318ea Compare September 23, 2024 13:06
@JanDintel
Copy link
Author

@ofek1weiss thank you for the review!
I've updated the file to remove the unnecessary white spacing and the previously failing pre-commit hook for prettier passed locally.

@JanDintel JanDintel force-pushed the multi-arch-docker-image branch from 77318ea to 9956a8d Compare September 23, 2024 13:12
@ofek1weiss ofek1weiss merged commit 0f4a215 into elementary-data:master Sep 23, 2024
@ofek1weiss
Copy link
Contributor

@JanDintel 🎉

@MikaKerman
Copy link
Contributor

Hey @JanDintel,
Thanks again for your PR adding multi-arch support. Unfortunately, we’re hitting QEMU segfaults on arm64 whenever certain packages trigger a libc reconfiguration, so we’ve had to revert the changes for now to keep our CI stable.

Out of curiosity, did you ever get a chance to build the image using QEMU and get it working there?

@JanDintel
Copy link
Author

@MikaKerman thank you for the update!

I was able to build a arm Docker image locally using QEMU, since this is provided by Docker Desktop. However I didn't verify it with the Github actions.

I'll investigate on my side whether I can propose a change which will also succeed in the Github actions.

@MikaKerman
Copy link
Contributor

Thank you so much!
Let me know if you'd like me to start the build image workflow for testing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for arm architecture in the published docker image

3 participants