Skip to content

Ele 3919 docs fixes #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joostboon merged 5 commits into from
Dec 23, 2024
Merged

Ele 3919 docs fixes #1769

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec75f75
Changed where timestamp_column is defined in models and example yaml
joostboon Dec 23, 2024
0709a7e
removed types-pkg-resources as it gives an error in the pre-commit ho…
joostboon Dec 23, 2024
7839dc5
fix yaml format
NoyaArie Dec 23, 2024
d86b262
Merge branch 'docs' into ele-3919-metrics-and-alert-rules-docs-fixes
joostboon Dec 23, 2024
5f14012
re-added types-pkg-resources to prevent merge conflict with master later
joostboon Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions docs/features/anomaly-detection/metrics.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,9 @@ No mandatory configuration, however it is highly recommended to configure a `tim
```yml Models
models:
- name: < model name >
config:
elementary:
timestamp_column: < timestamp column >
tests:
- elementary.collect_metrics:
timestamp_column: < timestamp column >
time_bucket: # Daily by default
period: < time period >
count: < number of periods >
Expand All @@ -68,11 +66,9 @@ models:

models:
- name: login_events
config:
elementary:
timestamp_column: 'loaded_at'
tests:
- elementary.collect_metrics:
timestamp_column: 'loaded_at'
time_bucket:
period: hour
count: 1
Expand All @@ -86,9 +82,9 @@ models:
type: row_count
- name: null_count
type: null_count
columns: [hello, world]
columns: ["hello", "world"]
where_expression: country = 'USA'
Copy link
Contributor Author

@NoyaArie NoyaArie Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
where_expression: country = 'USA'
where_expression: "country = 'USA'"

@joostboon wdyt?

Copy link

@joostboon joostboon Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

cloud_monitored=True
cloud_monitored: true

```

Expand Down
Loading