Skip to content

Extract exposure logic #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofek1weiss merged 1 commit into from
Jan 16, 2025
Merged

Extract exposure logic #1786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion elementary/monitor/api/report/report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ def _get_groups(
]
)

def _get_exposures(
self, models_api: ModelsAPI, upstream_node_ids: Optional[List[str]] = None
) -> Dict[str, NormalizedExposureSchema]:
return models_api.get_exposures(upstream_node_ids=upstream_node_ids)

def get_report_data(
self,
days_back: int = 7,
Expand Down Expand Up @@ -101,7 +106,9 @@ def get_report_data(
lineage_node_ids.extend(models.keys())
sources = models_api.get_sources()
lineage_node_ids.extend(sources.keys())
exposures = models_api.get_exposures(upstream_node_ids=lineage_node_ids)
exposures = self._get_exposures(
models_api, upstream_node_ids=lineage_node_ids
)
lineage_node_ids.extend(exposures.keys())
singular_tests = tests_api.get_singular_tests()

Expand Down
Loading