Ele 3960 adaptive cards #1795
Merged
Ele 3960 adaptive cards #1795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👋 @MikaKerman |
MikaKerman
force-pushed
the
ele-3960-adaptive-cards
branch
from
9312352 to
739b23f
Compare
ofek1weiss
reviewed
Feb 3, 2025
elementary/messages/blocks.py
Outdated
| ITALIC = "italic" | ||
|
|
||
|
|
||
| class BlockType(Enum): |
Contributor
There was a problem hiding this comment.
i think i would just do str
its used only for pydantic, so there wont be an issue of comparing to raw text, and it will probably become a kader if and when we want to add cloud specific blocks
- Introduced `BlockType` enum to define standardized block types - Updated block classes to include explicit type annotations using `Literal` types - Added type hints to base block classes to improve type safety
- Modified `blocks.py` and `message_body.py` to use `update_forward_refs()` instead of deprecated `model_rebuild()`
MikaKerman
force-pushed
the
ele-3960-adaptive-cards
branch
from
739b23f to
63e198c
Compare
ofek1weiss
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null