Ele 4028 messaging integ #1799
Merged
Ele 4028 messaging integ #1799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👋 @MikaKerman |
ofek1weiss
reviewed
Feb 6, 2025
| self, | ||
| destination: DestinationType, | ||
| message_context: MessageContextType, | ||
| message_body: MessageBody, |
Contributor
There was a problem hiding this comment.
the names are a little confusing, since the parameters regard different messages, maybe message_context and reply_body
Contributor
Author
There was a problem hiding this comment.
how about just body?
| channel: Optional[str] = None | ||
|
|
||
|
|
||
| def send_adaptive_card(webhook_url: str, card: dict) -> requests.Response: |
Contributor
There was a problem hiding this comment.
all of the comments in this method are redundant
| @@ -0,0 +1,84 @@ | |||
| from datetime import datetime | |||
Contributor
There was a problem hiding this comment.
this whole file is duplicated
- Moved alert grouping logic from integration to data monitoring alerts - Added support for grouping all alerts when threshold is met - Updated alert sending to handle individual alerts instead of bulk sending - Simplified alert processing and added type hints - Deprecated bulk alert sending methods in base integration
- Created base abstract class for messaging integrations with generic support - Implemented `BaseMessagingIntegration` with abstract methods for sending messages and checking reply support - Added custom exceptions for messaging integration errors - Introduced `MessageSendResult` generic model to track message sending context
MikaKerman
force-pushed
the
ele-4028-messaging-integ
branch
from
044b0c0 to
53b5c68
Compare
- Implemented `TeamsWebhookMessagingIntegration` for sending messages to Microsoft Teams - Created support for sending Adaptive Cards via webhook - Added error handling and logging for webhook message sending - Implemented method to check reply support (not supported for Teams)
- Created detailed documentation explaining the new messaging integration architecture - Described key components like `BaseMessagingIntegration` and migration strategy - Outlined implementation guidelines for new messaging platform integrations - Highlighted current and future support for messaging platforms
- Updated `DataMonitoringAlerts` to support both legacy and new messaging integrations - Implemented dual-path alert sending logic for BaseIntegration and BaseMessagingIntegration - Added `_send_message()` method to handle new messaging integration message sending - Created `get_health_check_message()` for test message support in new integrations - Updated `Integrations` class to support gradual migration to new messaging system - Added destination resolution method for messaging integrations
MikaKerman
force-pushed
the
ele-4028-messaging-integ
branch
from
53b5c68 to
e197ac6
Compare
- Updated parameter name from `message_body` to `body` in base messaging integration methods - Synchronized parameter naming across `BaseMessagingIntegration`, `TeamsWebhookMessagingIntegration`, and `DataMonitoringAlerts` - Simplified method signatures and improved consistency in messaging integration code - Updated README example to reflect new parameter naming convention
ofek1weiss
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null