Refactor alert message builder for improved type handling and simplif… #1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication - Added `_get_alert_color()` method to centralize color retrieval for alerts - Simplified `_get_alert_groups_blocks()` method by removing redundant type checking - Updated `build()` method to use new `_get_alert_color()` method - Narrowed type hints for alert groups processing - Removed unnecessary type branching in alert groups handling
Contributor
|
👋 @MikaKerman |
ofek1weiss
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ication
_get_alert_color()method to centralize color retrieval for alerts_get_alert_groups_blocks()method by removing redundant type checkingbuild()method to use new_get_alert_color()method