Skip to content

Handle missing asset name in test alert message generation #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikaKerman merged 1 commit into from
Feb 11, 2025
Merged

Handle missing asset name in test alert message generation #1811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions elementary/monitor/alerts/test_alert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,16 @@ def summary(self) -> str:
)

if self.test_type == "schema_change":
return f"{self.test_sub_type_display_name} on {asset_name}"
return f'"{self.concise_name}" test failed on {asset_name}'
return (
f"{self.test_sub_type_display_name} on {asset_name}"
if asset_name
else self.test_sub_type_display_name
)
return (
f'"{self.concise_name}" test failed on {asset_name}'
if asset_name
else f'"{self.concise_name}" test failed'
)

def get_report_link(self) -> Optional[ReportLinkData]:
return get_test_runs_link(self.report_url, self.elementary_unique_id)
2 changes: 1 addition & 1 deletion ...ription-False_tags-False_owners-False_table-False_error-False_sample-False_env-False.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "\"test_short_name\" test failed on ",
"text": "\"test_short_name\" test failed",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ...description-True_tags-False_owners-True_table-False_error-True_sample-False_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "Error: \"test_short_name\" test failed on ",
"text": "Error: \"test_short_name\" test failed",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ...ription-False_tags-False_owners-False_table-False_error-False_sample-False_env-False.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "Failure: \"test_short_name\" test failed on ",
"text": "Failure: \"test_short_name\" test failed",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ...tags-False_owners-False_table-False_error-False_sample-False_anomaly-False_env-False.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "Generic on ",
"text": "Generic",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ...rue_tags-False_owners-True_table-False_error-True_sample-False_anomaly-True_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "\"test_short_name\" test failed on ",
"text": "\"test_short_name\" test failed",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ...ue_tags-False_owners-False_table-False_error-True_sample-False_anomaly-True_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "Error: \"test_short_name\" test failed on ",
"text": "Error: \"test_short_name\" test failed",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ...tags-False_owners-False_table-False_error-False_sample-False_anomaly-False_env-False.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "Generic on ",
"text": "Generic",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ...ue_tags-False_owners-True_table-False_error-True_sample-False_anomaly-True_env-False.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "Warning: \"test_short_name\" test failed on ",
"text": "Warning: \"test_short_name\" test failed",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
Loading