Skip to content

Refactor alert message builder to improve type handling and error man… #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikaKerman merged 1 commit into from
Feb 12, 2025
Merged

Refactor alert message builder to improve type handling and error man… #1812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions elementary/monitor/alerts/alert_messages/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
)
from elementary.messages.message_body import Color, MessageBlock, MessageBody
from elementary.monitor.alerts.alerts_groups.alerts_group import AlertsGroup
from elementary.monitor.alerts.alerts_groups.base_alerts_group import BaseAlertsGroup
from elementary.monitor.alerts.alerts_groups.grouped_by_table import (
GroupedByTableAlerts,
)
Expand All @@ -43,8 +44,7 @@
TestAlertModel,
ModelAlertModel,
SourceFreshnessAlertModel,
GroupedByTableAlerts,
AlertsGroup,
BaseAlertsGroup,
]


Expand Down Expand Up @@ -477,6 +477,8 @@ def _get_alert_subtitle_blocks(
return self._get_run_alert_subtitle_blocks(alert)
elif isinstance(alert, AlertsGroup):
return self._get_alerts_group_subtitle_blocks(alert)
else:
raise ValueError(f"Unknown alert type: {type(alert)}")

def _get_alert_details_blocks(
self,
Expand Down Expand Up @@ -583,14 +585,17 @@ def _get_alert_config_blocks(

def _get_alert_groups_blocks(
self,
alert: AlertsGroup,
alert: BaseAlertsGroup,
) -> List[MessageBlock]:
return self._get_sub_alert_groups_blocks(
model_errors=alert.model_errors,
test_failures=alert.test_failures,
test_warnings=alert.test_warnings,
test_errors=alert.test_errors,
)
if isinstance(alert, AlertsGroup):
return self._get_sub_alert_groups_blocks(
model_errors=alert.model_errors,
test_failures=alert.test_failures,
test_warnings=alert.test_warnings,
test_errors=alert.test_errors,
)
else:
raise ValueError(f"Unknown alert type: {type(alert)}")

def build(
self,
Expand Down Expand Up @@ -619,7 +624,7 @@ def build(
config_blocks = self._get_alert_config_blocks(alert)
blocks.extend(config_blocks)

if isinstance(alert, AlertsGroup):
if isinstance(alert, BaseAlertsGroup):
alert_groups_blocks = self._get_alert_groups_blocks(alert)
blocks.extend(alert_groups_blocks)

Expand Down
Loading