Skip to content

Add support for displaying result messages in model alerts #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikaKerman merged 2 commits into from
Feb 16, 2025
Merged

Add support for displaying result messages in model alerts #1818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5489d41
Add support for displaying result messages in model alerts
MikaKerman Feb 15, 2025
e0ec7ae
Update Adaptive Cards test fixtures to version 1.5
MikaKerman Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elementary/monitor/alerts/alert_messages/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ def _get_alert_result_blocks(
)
title = "Test Result"
elif isinstance(alert, ModelAlertModel):
if alert.materialization == "snapshot":
if alert.message:
result_blocks = self._get_result_blocks(
result_message=alert.message,
)
Expand Down
48 changes: 47 additions & 1 deletion ...rs-True_path-False_suppression-True_materialization-table_full_refresh-True_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"actions": [
{
"type": "Action.ToggleVisibility",
"title": "Model Configuration",
"title": "Result",
"targetElements": [
"expandable-00000000-0000-0000-0000-000000000001"
]
Expand All @@ -76,6 +76,52 @@
{
"type": "Container",
"id": "expandable-00000000-0000-0000-0000-000000000001",
"items": [
{
"type": "Container",
"separator": true,
"items": [
{
"type": "TextBlock",
"text": "**Result Message**",
"wrap": true
},
{
"type": "Container",
"style": "emphasis",
"items": [
{
"type": "RichTextBlock",
"inlines": [
{
"type": "TextRun",
"text": "Database Error in table my_failed_dbt_model\n(models/example/my_failed_dbt_model.sql)\n syntax error at or near \")\"\n LINE 19: \t); \n\t\t^",
"fontType": "Monospace"
}
]
}
]
}
]
}
],
"isVisible": false
},
{
"type": "ActionSet",
"actions": [
{
"type": "Action.ToggleVisibility",
"title": "Model Configuration",
"targetElements": [
"expandable-00000000-0000-0000-0000-000000000002"
]
}
]
},
{
"type": "Container",
"id": "expandable-00000000-0000-0000-0000-000000000002",
"items": [
{
"type": "Container",
Expand Down
48 changes: 47 additions & 1 deletion ...rs-True_path-True_suppression-True_materialization-table_full_refresh-False_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"actions": [
{
"type": "Action.ToggleVisibility",
"title": "Model Configuration",
"title": "Result",
"targetElements": [
"expandable-00000000-0000-0000-0000-000000000001"
]
Expand All @@ -81,6 +81,52 @@
{
"type": "Container",
"id": "expandable-00000000-0000-0000-0000-000000000001",
"items": [
{
"type": "Container",
"separator": true,
"items": [
{
"type": "TextBlock",
"text": "**Result Message**",
"wrap": true
},
{
"type": "Container",
"style": "emphasis",
"items": [
{
"type": "RichTextBlock",
"inlines": [
{
"type": "TextRun",
"text": "Database Error in table my_failed_dbt_model\n(models/example/my_failed_dbt_model.sql)\n syntax error at or near \")\"\n LINE 19: \t); \n\t\t^",
"fontType": "Monospace"
}
]
}
]
}
]
}
],
"isVisible": false
},
{
"type": "ActionSet",
"actions": [
{
"type": "Action.ToggleVisibility",
"title": "Model Configuration",
"targetElements": [
"expandable-00000000-0000-0000-0000-000000000002"
]
}
]
},
{
"type": "Container",
"id": "expandable-00000000-0000-0000-0000-000000000002",
"items": [
{
"type": "Container",
Expand Down
48 changes: 47 additions & 1 deletion ..._path-True_suppression-False_materialization-incremental_full_refresh-True_env-False.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"actions": [
{
"type": "Action.ToggleVisibility",
"title": "Model Configuration",
"title": "Result",
"targetElements": [
"expandable-00000000-0000-0000-0000-000000000001"
]
Expand All @@ -76,6 +76,52 @@
{
"type": "Container",
"id": "expandable-00000000-0000-0000-0000-000000000001",
"items": [
{
"type": "Container",
"separator": true,
"items": [
{
"type": "TextBlock",
"text": "**Result Message**",
"wrap": true
},
{
"type": "Container",
"style": "emphasis",
"items": [
{
"type": "RichTextBlock",
"inlines": [
{
"type": "TextRun",
"text": "Database Error in incremental my_failed_dbt_model\n(models/example/my_failed_dbt_model.sql)\n syntax error at or near \")\"\n LINE 19: \t); \n\t\t^",
"fontType": "Monospace"
}
]
}
]
}
]
}
],
"isVisible": false
},
{
"type": "ActionSet",
"actions": [
{
"type": "Action.ToggleVisibility",
"title": "Model Configuration",
"targetElements": [
"expandable-00000000-0000-0000-0000-000000000002"
]
}
]
},
{
"type": "Container",
"id": "expandable-00000000-0000-0000-0000-000000000002",
"items": [
{
"type": "Container",
Expand Down
48 changes: 47 additions & 1 deletion ...rs-False_path-False_suppression-True_materialization-view_full_refresh-True_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"actions": [
{
"type": "Action.ToggleVisibility",
"title": "Model Configuration",
"title": "Result",
"targetElements": [
"expandable-00000000-0000-0000-0000-000000000001"
]
Expand All @@ -81,6 +81,52 @@
{
"type": "Container",
"id": "expandable-00000000-0000-0000-0000-000000000001",
"items": [
{
"type": "Container",
"separator": true,
"items": [
{
"type": "TextBlock",
"text": "**Result Message**",
"wrap": true
},
{
"type": "Container",
"style": "emphasis",
"items": [
{
"type": "RichTextBlock",
"inlines": [
{
"type": "TextRun",
"text": "Database Error in view my_failed_dbt_model\n(models/example/my_failed_dbt_model.sql)\n syntax error at or near \")\"\n LINE 19: \t); \n\t\t^",
"fontType": "Monospace"
}
]
}
]
}
]
}
],
"isVisible": false
},
{
"type": "ActionSet",
"actions": [
{
"type": "Action.ToggleVisibility",
"title": "Model Configuration",
"targetElements": [
"expandable-00000000-0000-0000-0000-000000000002"
]
}
]
},
{
"type": "Container",
"id": "expandable-00000000-0000-0000-0000-000000000002",
"items": [
{
"type": "Container",
Expand Down
48 changes: 47 additions & 1 deletion ..._path-True_suppression-False_materialization-incremental_full_refresh-True_env-False.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"actions": [
{
"type": "Action.ToggleVisibility",
"title": "Model Configuration",
"title": "Result",
"targetElements": [
"expandable-00000000-0000-0000-0000-000000000001"
]
Expand All @@ -81,6 +81,52 @@
{
"type": "Container",
"id": "expandable-00000000-0000-0000-0000-000000000001",
"items": [
{
"type": "Container",
"separator": true,
"items": [
{
"type": "TextBlock",
"text": "**Result Message**",
"wrap": true
},
{
"type": "Container",
"style": "emphasis",
"items": [
{
"type": "RichTextBlock",
"inlines": [
{
"type": "TextRun",
"text": "Database Error in incremental my_failed_dbt_model\n(models/example/my_failed_dbt_model.sql)\n syntax error at or near \")\"\n LINE 19: \t); \n\t\t^",
"fontType": "Monospace"
}
]
}
]
}
]
}
],
"isVisible": false
},
{
"type": "ActionSet",
"actions": [
{
"type": "Action.ToggleVisibility",
"title": "Model Configuration",
"targetElements": [
"expandable-00000000-0000-0000-0000-000000000002"
]
}
]
},
{
"type": "Container",
"id": "expandable-00000000-0000-0000-0000-000000000002",
"items": [
{
"type": "Container",
Expand Down
48 changes: 47 additions & 1 deletion ...ers-True_path-True_suppression-True_materialization-table_full_refresh-True_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"actions": [
{
"type": "Action.ToggleVisibility",
"title": "Model Configuration",
"title": "Result",
"targetElements": [
"expandable-00000000-0000-0000-0000-000000000001"
]
Expand All @@ -81,6 +81,52 @@
{
"type": "Container",
"id": "expandable-00000000-0000-0000-0000-000000000001",
"items": [
{
"type": "Container",
"separator": true,
"items": [
{
"type": "TextBlock",
"text": "**Result Message**",
"wrap": true
},
{
"type": "Container",
"style": "emphasis",
"items": [
{
"type": "RichTextBlock",
"inlines": [
{
"type": "TextRun",
"text": "Database Error in table my_failed_dbt_model\n(models/example/my_failed_dbt_model.sql)\n syntax error at or near \")\"\n LINE 19: \t); \n\t\t^",
"fontType": "Monospace"
}
]
}
]
}
]
}
],
"isVisible": false
},
{
"type": "ActionSet",
"actions": [
{
"type": "Action.ToggleVisibility",
"title": "Model Configuration",
"targetElements": [
"expandable-00000000-0000-0000-0000-000000000002"
]
}
]
},
{
"type": "Container",
"id": "expandable-00000000-0000-0000-0000-000000000002",
"items": [
{
"type": "Container",
Expand Down
Loading
Loading