Skip to content

Added formatting needed for critical assets #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ofek1weiss merged 5 commits into from
Feb 20, 2025
Merged

Added formatting needed for critical assets #1831

ofek1weiss merged 5 commits into from
Feb 20, 2025

Conversation

@ofek1weiss
Copy link
Contributor

@ofek1weiss ofek1weiss commented Feb 19, 2025 •
edited
Loading

  • indenting of bullet list
    • needed to implement whitespace block since adaptive cards ignores leading whitespaces
  • gem icon
  • action blocks
    • dropdown
    • user select
  • user id for message body

@linear
Copy link

linear bot commented Feb 19, 2025

ELE-4073 rich critical assets

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025

👋 @ofek1weiss
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

MikaKerman
MikaKerman approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@MikaKerman MikaKerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@ofek1weiss ofek1weiss merged commit fd0321d into master Feb 20, 2025
4 checks passed
@ofek1weiss ofek1weiss deleted the ele-4073-rich-critical-assets branch February 20, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikaKerman MikaKerman MikaKerman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ofek1weiss @MikaKerman