Skip to content

Enhance test result handling by adding test_description field #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikaKerman merged 1 commit into from
Apr 1, 2025
Merged

Enhance test result handling by adding test_description field #1875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion elementary/monitor/api/tests/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,10 @@ def _get_test_metadata_from_test_result_db_row(
test_query=test_query,
test_params=test_result_db_row.test_params,
test_created_at=test_result_db_row.test_created_at,
description=test_result_db_row.meta.get("description"),
description=(
test_result_db_row.test_description
or test_result_db_row.meta.get("description")
),
result=result,
configuration=configuration,
test_tags=test_result_db_row.test_tags,
Expand Down
1 change: 1 addition & 0 deletions elementary/monitor/dbt_project/macros/base_queries/current_tests_run_results_query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@
elementary_test_results.result_rows,
dbt_tests.original_path,
dbt_tests.meta,
dbt_tests.description as test_description,
dbt_tests.package_name,
dbt_tests.tags as test_tags,
dbt_artifacts.meta as model_meta,
Expand Down
1 change: 1 addition & 0 deletions elementary/monitor/dbt_project/macros/get_test_results.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
test_results.test_type,
test_results.test_sub_type,
test_results.test_results_description,
test_results.test_description,
test_results.original_path,
test_results.package_name,
test_results.owners,
Expand Down
1 change: 1 addition & 0 deletions elementary/monitor/fetchers/tests/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ class TestResultDBRowSchema(ExtendedBaseModel):
test_type: str
test_sub_type: str
test_results_description: Optional[str]
test_description: Optional[str]
original_path: str
owners: Optional[List[str]]
model_owner: Optional[List[str]]
Expand Down