-
Notifications
You must be signed in to change notification settings - Fork 205
added dbt_groups to docs #1923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added dbt_groups to docs #1923
Conversation
|
👋 @arbiv |
WalkthroughThe documentation was updated to include new sections describing the Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/dbt/package-models.mdx (1)
117-123: Use Code Formatting for Column NamesConsider wrapping column names in backticks for consistency and clarity (e.g.,
group_name,owner).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/dbt/dbt-artifacts.mdx(1 hunks)docs/dbt/package-models.mdx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: code-quality
🔇 Additional comments (2)
docs/dbt/package-models.mdx (1)
117-123: Ensure thedbt_groupsModel Exists in the CodebasePlease verify that the
dbt_groupsmodel file is implemented and included in the package (e.g.,models/edr/dbt_artifacts/dbt_groups.sql) so the documentation aligns with the actual code.docs/dbt/dbt-artifacts.mdx (1)
81-84: Validate Artifact Model ImplementationConfirm that the
dbt_groupsartifact model SQL file exists under thedbt_artifactsfolder and is populated on each run, ensuring the docs accurately reflect the package behavior.
null
Summary by CodeRabbit
dbt_groupsmodel and table, including details about group properties and metadata, to the dbt artifact and package model documentation.