Skip to content

ignore monitor failure on clickhouse #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-myaskovsky merged 6 commits into from
Jun 16, 2025
Merged

ignore monitor failure on clickhouse #1934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fe5768c
ignore monitor failure on clickhouse
michael-myaskovsky Jun 16, 2025
e1c4c99
skipped report too
michael-myaskovsky Jun 16, 2025
f6357f5
skipped send report too
michael-myaskovsky Jun 16, 2025
99ae68f
skipped e2e tests
michael-myaskovsky Jun 16, 2025
282bbf0
removed clickhouse from tests
michael-myaskovsky Jun 16, 2025
71ab728
removed from other github workflows as well
michael-myaskovsky Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions .github/workflows/test-all-warehouses.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,7 @@ jobs:
matrix:
dbt-version: ${{ inputs.dbt-version && fromJSON(format('["{0}"]', inputs.dbt-version)) || fromJSON('["1.8.0", null]') }}
warehouse-type:
[
postgres,
snowflake,
bigquery,
redshift,
databricks_catalog,
athena,
clickhouse,
]
[postgres, snowflake, bigquery, redshift, databricks_catalog, athena]
uses: ./.github/workflows/test-warehouse.yml
with:
warehouse-type: ${{ matrix.warehouse-type }}
Expand Down
10 changes: 1 addition & 9 deletions .github/workflows/test-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,7 @@ jobs:
fail-fast: false
matrix:
warehouse-type:
[
postgres,
snowflake,
bigquery,
redshift,
databricks_catalog,
athena,
clickhouse,
]
[postgres, snowflake, bigquery, redshift, databricks_catalog, athena]
needs: get-latest-release-tags
uses: ./.github/workflows/test-warehouse.yml
with:
Expand Down
11 changes: 4 additions & 7 deletions .github/workflows/test-warehouse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ on:
- databricks_catalog
- spark
- athena
- clickhouse
elementary-ref:
type: string
required: false
Expand Down Expand Up @@ -105,10 +104,10 @@ jobs:
working-directory: ${{ env.DBT_PKG_INTEG_TESTS_DIR }}
run: docker compose up -d postgres

- name: Start Clickhouse
if: inputs.warehouse-type == 'clickhouse'
working-directory: ${{ env.DBT_PKG_INTEG_TESTS_DIR }}
run: docker compose up -d clickhouse
# - name: Start Clickhouse
# if: inputs.warehouse-type == 'clickhouse'
# working-directory: ${{ env.DBT_PKG_INTEG_TESTS_DIR }}
# run: docker compose up -d clickhouse

- name: Setup Python
uses: actions/setup-python@v4
Expand Down Expand Up @@ -156,8 +155,6 @@ jobs:

- name: Run dbt package integration tests
if: github.event_name != 'workflow_dispatch' || inputs.should-run-tests
# remove this once clickhouse supports anomaly detection
continue-on-error: ${{ inputs.warehouse-type == 'clickhouse' }}
working-directory: ${{ env.DBT_PKG_INTEG_TESTS_DIR }}
run: |
dbt deps
Expand Down