-
Notifications
You must be signed in to change notification settings - Fork 205
make the venv in-project in the CLI #1938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
👋 @haritamar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
poetry.toml (1)
1-2: Exclude the.venv/directory from VCS
Since Poetry will now generate a.venv/folder at the project root, remember to add.venv/to.gitignore(and.dockerignoreif you use one) to avoid committing your virtual environment.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
poetry.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: code-quality
🔇 Additional comments (1)
poetry.toml (1)
1-2: Enable in-project virtual environments
The new[virtualenvs] in-project = truesection correctly instructs Poetry to create a.venvfolder inside the project directory for isolated, per-project environments.
null
Summary by CodeRabbit