Skip to content

using elementary 0.19.0 #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arbiv merged 1 commit into from
Jun 22, 2025
Merged

using elementary 0.19.0 #1942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions elementary/monitor/dbt_project/package-lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
packages:
- package: dbt-labs/dbt_utils
version: 0.8.6
- git: https://github.com/elementary-data/dbt-data-reliability.git
revision: 59270ed6a84ed6d4e9d449bc2725643771389cae
sha1_hash: 109654c5f1fcc533140ae5e64c784ab0e16a6b06
- package: elementary-data/elementary
version: 0.19.0
sha1_hash: 5ed509a5a7446d8cf2c72bd5ec8589a9e16b5e36
Comment on lines +4 to +6
Copy link

@coderabbitai coderabbitai bot Jun 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Indentation error: sha1_hash must be nested under the package entry
As shown, sha1_hash is currently a top-level key. It should be indented under the elementary-data/elementary list item or it will break the lockfile format.

Apply this diff:

-  - package: elementary-data/elementary
-    version: 0.19.0
-sha1_hash: 5ed509a5a7446d8cf2c72bd5ec8589a9e16b5e36
+  - package: elementary-data/elementary
+    version: 0.19.0
+    sha1_hash: 5ed509a5a7446d8cf2c72bd5ec8589a9e16b5e36
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- package: elementary-data/elementary
version: 0.19.0
sha1_hash: 5ed509a5a7446d8cf2c72bd5ec8589a9e16b5e36
- package: elementary-data/elementary
version: 0.19.0
sha1_hash: 5ed509a5a7446d8cf2c72bd5ec8589a9e16b5e36
🤖 Prompt for AI Agents 
In elementary/monitor/dbt_project/package-lock.yml around lines 4 to 6, the
sha1_hash key is incorrectly placed at the top level instead of being nested
under the package entry for elementary-data/elementary. Fix this by indenting
sha1_hash so it is a child of the package entry, aligning it properly under the
version key to maintain correct YAML structure and lockfile format.

4 changes: 2 additions & 2 deletions elementary/monitor/dbt_project/packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
packages:
- package: dbt-labs/dbt_utils
version: [">=0.8.0", "<0.9.0"]
- git: https://github.com/elementary-data/dbt-data-reliability.git
revision: 59270ed6a84ed6d4e9d449bc2725643771389cae
- package: elementary-data/elementary
version: 0.19.0

# NOTE - for unreleased CLI versions we often need to update the package version to a commit hash (please leave this
# commented, so it will be easy to access)
Expand Down