Skip to content

Ele 4832 full source name in freshness alerts #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofek1weiss merged 3 commits into from
Jul 28, 2025
Merged

Ele 4832 full source name in freshness alerts #1971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15751e2
full name in summary
ofek1weiss Jul 28, 2025
4a7348b
fixed tests
ofek1weiss Jul 28, 2025
8f1bb0f
use fqn
ofek1weiss Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions elementary/monitor/alerts/source_freshness_alert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,16 @@ def error_message(self) -> str:

@property
def summary(self) -> str:
source_fqn = ".".join(
[
part
for part in [self.database_name, self.schema_name, self.identifier]
if part
]
)
if self.original_status == "runtime error":
return f'Failed to calculate the source freshness of "{self.source_name}"'
return f'Freshness exceeded the acceptable times on source "{self.source_name}"'
return f'Failed to calculate the source freshness of "{source_fqn}"'
return f'Freshness exceeded the acceptable times on source "{source_fqn}"'

def get_report_link(self) -> Optional[ReportLinkData]:
return get_test_runs_link(self.report_url, self.source_freshness_execution_id)
2 changes: 1 addition & 1 deletion ...message-False_tags-True_owners-True_path-True_error-True_suppression-False_env-False.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "Error: Freshness exceeded the acceptable times on source \"test_source\"",
"text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\"",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ..._message-True_tags-True_owners-True_path-False_error-True_suppression-False_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "Error: Freshness exceeded the acceptable times on source \"test_source\"",
"text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\"",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ...sage-False_tags-False_owners-False_path-False_error-False_suppression-True_env-False.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "Error: Freshness exceeded the acceptable times on source \"test_source\"",
"text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\"",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ...message-False_tags-True_owners-True_path-True_error-False_suppression-True_env-False.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "Error: Freshness exceeded the acceptable times on source \"test_source\"",
"text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\"",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ..._message-True_tags-False_owners-False_path-True_error-True_suppression-True_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "Error: Freshness exceeded the acceptable times on source \"test_source\"",
"text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\"",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ...age-False_tags-False_owners-False_path-False_error-False_suppression-False_env-False.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "Runtime Error: Failed to calculate the source freshness of \"test_source\"",
"text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\"",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ..._message-True_tags-True_owners-False_path-False_error-True_suppression-True_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "Runtime Error: Failed to calculate the source freshness of \"test_source\"",
"text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\"",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ...message-False_tags-True_owners-False_path-True_error-False_suppression-True_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "Runtime Error: Failed to calculate the source freshness of \"test_source\"",
"text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\"",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ...message-True_tags-False_owners-True_path-False_error-True_suppression-False_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "Runtime Error: Failed to calculate the source freshness of \"test_source\"",
"text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\"",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ...ue_message-True_tags-True_owners-True_path-True_error-True_suppression-True_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"items": [
{
"type": "TextBlock",
"text": "Runtime Error: Failed to calculate the source freshness of \"test_source\"",
"text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\"",
"weight": "bolder",
"size": "large",
"wrap": true
Expand Down
2 changes: 1 addition & 1 deletion ...message-False_tags-True_owners-True_path-True_error-True_suppression-False_env-False.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "header",
"text": {
"type": "plain_text",
"text": "Error: Freshness exceeded the acceptable times on source \"test_source\""
"text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\""
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion ..._message-True_tags-True_owners-True_path-False_error-True_suppression-False_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "header",
"text": {
"type": "plain_text",
"text": "Error: Freshness exceeded the acceptable times on source \"test_source\""
"text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\""
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion ...sage-False_tags-False_owners-False_path-False_error-False_suppression-True_env-False.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "header",
"text": {
"type": "plain_text",
"text": "Error: Freshness exceeded the acceptable times on source \"test_source\""
"text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\""
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion ...message-False_tags-True_owners-True_path-True_error-False_suppression-True_env-False.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "header",
"text": {
"type": "plain_text",
"text": "Error: Freshness exceeded the acceptable times on source \"test_source\""
"text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\""
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion ..._message-True_tags-False_owners-False_path-True_error-True_suppression-True_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "header",
"text": {
"type": "plain_text",
"text": "Error: Freshness exceeded the acceptable times on source \"test_source\""
"text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\""
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion ...age-False_tags-False_owners-False_path-False_error-False_suppression-False_env-False.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "header",
"text": {
"type": "plain_text",
"text": "Runtime Error: Failed to calculate the source freshness of \"test_source\""
"text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\""
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion ..._message-True_tags-True_owners-False_path-False_error-True_suppression-True_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "header",
"text": {
"type": "plain_text",
"text": "Runtime Error: Failed to calculate the source freshness of \"test_source\""
"text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\""
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion ...message-False_tags-True_owners-False_path-True_error-False_suppression-True_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "header",
"text": {
"type": "plain_text",
"text": "Runtime Error: Failed to calculate the source freshness of \"test_source\""
"text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\""
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion ...message-True_tags-False_owners-True_path-False_error-True_suppression-False_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "header",
"text": {
"type": "plain_text",
"text": "Runtime Error: Failed to calculate the source freshness of \"test_source\""
"text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\""
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion ...ue_message-True_tags-True_owners-True_path-True_error-True_suppression-True_env-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "header",
"text": {
"type": "plain_text",
"text": "Runtime Error: Failed to calculate the source freshness of \"test_source\""
"text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\""
}
},
{
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/alerts/alert_messages/test_alert_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,8 @@ def build_base_source_freshness_alert_model(
return SourceFreshnessAlertModel(
id="test_id",
source_name="test_source",
database_name="test_db",
schema_name="test_schema",
identifier="test_identifier",
original_status=status,
path=path,
Expand Down