Skip to content

Slack join channel recursion fix #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikaKerman merged 1 commit into from
Aug 15, 2025
Merged

Slack join channel recursion fix #1984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions elementary/messages/messaging_integrations/slack_web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def _handle_send_err(self, err: SlackApiError, channel_name: str):
logger.info(
f'Elementary app is not in the channel "{channel_name}". Attempting to join.'
)
channel_id = self._get_channel_id(channel_name)
channel_id = self._get_channel_id(channel_name, only_public=True)
self._join_channel(channel_id=channel_id)
logger.info(f"Joined channel {channel_name}")
elif err_type == "channel_not_found":
Expand All @@ -127,10 +127,12 @@ def _handle_send_err(self, err: SlackApiError, channel_name: str):

@sleep_and_retry
@limits(calls=20, period=ONE_MINUTE)
def _iter_channels(self, cursor: Optional[str] = None) -> Iterator[dict]:
def _iter_channels(
self, cursor: Optional[str] = None, only_public: bool = False
) -> Iterator[dict]:
response = self.client.conversations_list(
cursor=cursor,
types="public_channel,private_channel",
types="public_channel" if only_public else "public_channel,private_channel",
exclude_archived=True,
limit=1000,
)
Expand All @@ -141,10 +143,10 @@ def _iter_channels(self, cursor: Optional[str] = None) -> Iterator[dict]:
if next_cursor:
if not isinstance(next_cursor, str):
raise ValueError("Next cursor is not a string")
yield from self._iter_channels(next_cursor)
yield from self._iter_channels(next_cursor, only_public)

def _get_channel_id(self, channel_name: str) -> str:
for channel in self._iter_channels():
def _get_channel_id(self, channel_name: str, only_public: bool = False) -> str:
for channel in self._iter_channels(only_public=only_public):
if channel["name"] == channel_name:
return channel["id"]
raise MessagingIntegrationError(f"Channel {channel_name} not found")
Expand Down
Loading