Skip to content

Fix: Properly quote database and schema identifiers for SQL compatibility #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elazarlachkar merged 15 commits into from
Dec 2, 2025
Merged

Fix: Properly quote database and schema identifiers for SQL compatibility #1987

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9c91661
use sets for alert filters
ofek1weiss Aug 24, 2025
930cf84
extract normalization
ofek1weiss Aug 24, 2025
5d423c6
isort
ofek1weiss Aug 24, 2025
5af40f2
Fix: Replace double quotes with single quotes in elementary_database_…
mschmid09 Aug 19, 2025
2734f78
Replace double quotes with backticks for better SQL compatibility
mschmid09 Aug 19, 2025
a3a3581
Wrap each identifier part in double quotes for standard SQL compatibi…
mschmid09 Aug 25, 2025
701198f
Merge remote-tracking branch 'upstream/master' into fix/replace-doubl…
mschmid09 Sep 1, 2025
0c35a56
Merge remote-tracking branch 'upstream/master' into fix/replace-doubl…
mschmid09 Sep 2, 2025
143bdea
Merge branch 'master' into fix/replace-double-quotes-with-single-quotes
mschmid09 Sep 3, 2025
2ca8e55
Merge branch 'master' into fix/replace-double-quotes-with-single-quotes
mschmid09 Sep 4, 2025
6b5a7b6
Merge branch 'master' into fix/replace-double-quotes-with-single-quotes
mschmid09 Sep 16, 2025
057320e
Merge branch 'master' into fix/replace-double-quotes-with-single-quotes
mschmid09 Sep 18, 2025
1fe1ed3
Merge branch 'master' into fix/replace-double-quotes-with-single-quotes
arbiv Nov 11, 2025
da1246a
Simplify by just stripping the "
mschmid09 Dec 2, 2025
a4d5a1c
Merge branch 'master' into fix/replace-double-quotes-with-single-quotes
mschmid09 Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions elementary/monitor/data_monitoring/data_monitoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,10 @@ def get_elementary_database_and_schema(self):
relation = self.internal_dbt_runner.run_operation(
"elementary_cli.get_elementary_database_and_schema", quiet=True
)[0]
logger.info(f"Elementary's database and schema: '{relation}'")
return relation
# Strip quotes from relation to avoid case sensitivity issues and double-quoting
strip_relation = relation.strip('"')
logger.info(f"Elementary's database and schema: '{strip_relation}'")
return strip_relation
except Exception as ex:
logger.error("Failed to parse Elementary's database and schema.")
if self.tracking:
Expand Down
Loading