Skip to content

Conversation

@NoyaArie
Copy link
Contributor

@NoyaArie NoyaArie commented Aug 31, 2025

null

Summary by CodeRabbit

  • Chores
    • Standardized schema naming in test workflows to include the warehouse type, use lowercase, and replace separators with underscores. Names are now truncated at 40 characters for consistency. Generated schemas (e.g., py_) will reflect the new convention across branches and dbt versions.
  • Style
    • Removed trailing spaces in two CLI commands to improve formatting.

@NoyaArie NoyaArie had a problem deploying to elementary_test_env August 31, 2025 10:56 — with GitHub Actions Failure
@github-actions
Copy link
Contributor

👋 @NoyaArie
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@coderabbitai
Copy link

coderabbitai bot commented Aug 31, 2025

Walkthrough

The workflow updates adjust how UNDERSCORED_REF_NAME is generated in the “Write dbt profiles” step to include a warehouse-type prefix, lowercase it, replace hyphens/slashes with underscores, and truncate to 40 chars. Minor trailing-space cleanups were made in two edr commands. No other changes.

Changes

Cohort / File(s) Summary
CI workflow updates
.github/workflows/test-warehouse.yml
Updated UNDERSCORED_REF_NAME to ${inputs.warehouse-type}_dbt_${DBT_VERSION}_${BRANCH_NAME} with tolower, 40-char truncation, and s/[-\/]/_/g; <SCHEMA_NAME> now uses py_<lowercased_prefixed_name>. Removed trailing spaces in edr monitor and edr monitor send-report lines.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor GH as GitHub Actions
  participant StepA as Write dbt profiles
  participant DBT as dbt Profile

  GH->>StepA: Provide inputs (warehouse-type, DBT_VERSION, BRANCH_NAME)
  StepA->>StepA: Build name = ${warehouse}-dbt-${version}-${branch}
  StepA->>StepA: tolower, replace [-/] with _, truncate to 40
  StepA->>DBT: Set UNDERSCORED_REF_NAME and <SCHEMA_NAME>=py_<name>
  GH->>DBT: Proceed with subsequent steps using updated schema
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my whiskers at YAML night,
New names hop in—lowercased, tight.
Slashes and dashes, now soft as snow,
Underscores trail where branches go.
Forty chars snug, schemas align—
A rabbit approves: “Looks fine, divine!” 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 503e3e2 and ac0cc87.

📒 Files selected for processing (1)
  • .github/workflows/test-warehouse.yml (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: code-quality
🔇 Additional comments (3)
.github/workflows/test-warehouse.yml (3)

171-176: Whitespace cleanup looks good.

No functional change; keep as is.


209-225: Whitespace cleanup looks good.

No functional change; keep as is.


139-140: Harden schema-name sanitization

-          UNDERSCORED_REF_NAME=$(echo "${{ inputs.warehouse-type }}_dbt_${DBT_VERSION}_${BRANCH_NAME}" | awk '{print tolower($0)}' | head -c 40 | sed "s/[-\/]/_/g")
+          UNDERSCORED_REF_NAME=$(
+            echo "${{ inputs.warehouse-type }}_dbt_${DBT_VERSION}_${BRANCH_NAME}" \
+            | tr '[:upper:]' '[:lower:]' \
+            | sed -E 's/[^a-z0-9_]/_/g; s/_+/_/g' \
+            | sed -E 's/^_+//; s/_+$//' \
+            | cut -c1-40
+          )

Verified with various branch names: special chars replaced, repeats collapsed, edges trimmed, length capped.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-ci-test-dwh-write-dbt-profiles

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@NoyaArie NoyaArie merged commit 133b631 into master Aug 31, 2025
5 of 6 checks passed
@NoyaArie NoyaArie deleted the fix-ci-test-dwh-write-dbt-profiles branch August 31, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants