Skip to content

require approval only for fork PRs #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haritamar merged 2 commits into from
Sep 10, 2025
Merged

require approval only for fork PRs #2004

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c6d41d
require approval only for fork PRs
haritamar Sep 8, 2025
b0f7358
change job name
haritamar Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/test-warehouse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,25 @@ env:
ELMENTARY_INTERNAL_DBT_PKG_DIR: ${{ github.workspace }}/elementary/elementary/monitor/dbt_project

jobs:
# PRs from forks require approval, specifically with the "pull_request_target" event as it contains repo secrets.
check-if-requires-approval:
runs-on: ubuntu-latest
outputs:
requires_approval: ${{ steps.set-output.outputs.requires_approval }}
steps:
- name: Set requires approval output
id: set-output
run: |
if [[ "${{ github.event_name }}" == "pull_request_target" && "${{ github.event.pull_request.head.repo.full_name }}" != "${{ github.repository }}" ]]; then
echo "requires_approval=true" >> $GITHUB_OUTPUT
else
echo "requires_approval=false" >> $GITHUB_OUTPUT
fi

test:
runs-on: ubuntu-latest
environment: elementary_test_env # This is a github environment (not to be confused with env vars)
needs: [check-if-requires-approval]
environment: ${{ (needs.check-if-requires-approval.outputs.requires_approval == 'true' && 'elementary_test_env') || '' }}
defaults:
run:
working-directory: elementary
Expand Down
Loading