Skip to content

Handle invalid characters when uploading CI artifact #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elazarlachkar merged 3 commits into from
Sep 10, 2025
Merged

Handle invalid characters when uploading CI artifact #2005

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae6f024
Handle invalid characters when uploading CI artifact
elazarlachkar Sep 9, 2025
5ae0ada
Fix sed pattern
elazarlachkar Sep 9, 2025
93d7921
Merge branch 'master' into ele-5052-oss-fix-ci-artifact-upload
elazarlachkar Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/test-warehouse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,10 +204,16 @@ jobs:
--project-dir "${{ env.DBT_PKG_INTEG_TESTS_DIR }}"
--project-profile-target "${{ inputs.warehouse-type }}"

- name: Set report artifact name
id: set_report_artifact_name
run: |
ARTIFACT_NAME=$(echo "report_${{ inputs.warehouse-type }}_${BRANCH_NAME}_dbt_${{ inputs.dbt-version || '' }}.html" | awk '{print tolower($0)}' | sed 's#[":/\\<>|*?-]#_#g')
echo "artifact_name=$ARTIFACT_NAME" >> "$GITHUB_OUTPUT"

- name: Upload report artifact
uses: actions/upload-artifact@v4
with:
name: report_${{ inputs.warehouse-type }}_${{ env.BRANCH_NAME }}_dbt_${{ inputs.dbt-version }}.html
name: ${{ steps.set_report_artifact_name.outputs.artifact_name }}
path: elementary/edr_target/elementary_report.html

- name: Write GCS keyfile
Expand Down Expand Up @@ -239,11 +245,17 @@ jobs:
--azure-container-name reports
--update-bucket-website true

- name: Set artifact name
id: set_artifact_name
run: |
ARTIFACT_NAME=$(echo "edr_${{ inputs.warehouse-type }}_${BRANCH_NAME}_dbt_${{ inputs.dbt-version || '' }}.log" | awk '{print tolower($0)}' | sed 's#[":/\\<>|*?-]#_#g')
echo "artifact_name=$ARTIFACT_NAME" >> "$GITHUB_OUTPUT"

- name: Upload edr log
if: ${{ always() }}
uses: actions/upload-artifact@v4
with:
name: edr_${{ inputs.warehouse-type }}_${{ env.BRANCH_NAME }}_dbt_${{ inputs.dbt-version }}.log
name: ${{ steps.set_artifact_name.outputs.artifact_name }}
path: elementary/edr_target/edr.log

- name: Run Python package e2e tests
Expand Down