package-lock: remove name to avoid breaking old dbt versions

[haritamar]

null

Summary by CodeRabbit

• Chores
  • Cleaned dependency lock entries by removing redundant name fields while preserving package versions and integrity checks.
  • Simplified CI dbt installation logic by removing a special-case constraint for one warehouse type and using a consistent package spec; optional version pinning preserved.
  • No functional changes, no dependencies added or removed, and no behavior differences for end users.

[linear]

ELE-5128 package-lock fix for older versions

[github-actions]

👋 @haritamar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Removes explicit name fields from two package entries in elementary/monitor/dbt_project/package-lock.yml and changes the GitHub Actions dbt-install step to always use the warehouse-type package spec (dropping the prior special-case databricks<1.10.2 constraint). No versions or hashes were changed.

Changes

Cohort / File(s)	Summary of Changes
Lockfile normalization elementary/monitor/dbt_project/package-lock.yml	Deleted explicit name fields for dbt_utils and elementary entries; preserved package, version, and sha1_hash values; no other edits.
CI workflow: dbt install logic .github/workflows/test-warehouse.yml	Simplified dbt install string: removed conditional injection of databricks<1.10.2 and now always uses warehouse-type (with optional @dbt-version pinning); removed the TODO special-case branch.

Sequence Diagram(s)

Old vs new control flow for selecting the dbt package string in the workflow.

sequenceDiagram
    participant GH as GitHub Actions
    participant Step as install-dbt step
    participant Shell as Shell

    rect rgb(230,245,255)
    Note right of GH: Old flow — conditional databricks constraint
    end

    GH->>Step: trigger install step
    Step->>Shell: evaluate warehouse-type and databricks flag
    Shell-->>Step: if databricks -> package = "{warehouse-type}+databricks<1.10.2"
    Shell-->>Step: else -> package = "{warehouse-type}{optional @version}"
    Step->>GH: run pip install with package string

Loading

sequenceDiagram
    participant GH as GitHub Actions
    participant Step as install-dbt step
    participant Shell as Shell

    rect rgb(235,255,235)
    Note right of GH: New flow — unified package spec
    end

    GH->>Step: trigger install step
    Step->>Shell: evaluate warehouse-type
    Shell-->>Step: package = "{warehouse-type}{optional @version}"
    Step->>GH: run pip install with package string

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• ele 4942 update lock file #1996 — Removes explicit name fields for dbt_utils and elementary in the same lockfile.
• dbt-databricks must be <1.10.2 #1939 — Modifies the GitHub Actions dbt install logic (adds/removes databricks special-case).
• changed dbt package version to a commit with dremio types mapping. ne… #1985 — Edits the elementary dependency entry in the same lockfile.

Suggested reviewers

• elazarlachkar
• michael-myaskovsky

Poem

I twitch my whiskers, nibble a byte,
Names hopped away in the quiet night.
Lockfile stays steady, hashes tight and light,
CI trimmed a branch and now installs just right.
Hoppity hop — tests take flight! 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly captures the primary change of removing name fields from the package-lock to avoid breaking compatibility with older dbt versions and aligns with the main modifications.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3f39e4e and 0872e70.

📒 Files selected for processing (1)

• .github/workflows/test-warehouse.yml (1 hunks)

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 113af44 and 3f39e4e.

📒 Files selected for processing (1)

• .github/workflows/test-warehouse.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: test
• GitHub Check: code-quality