Added more detailed exception for teams webhook failure

[ofek1weiss]

null

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling for Microsoft Teams webhook notifications. When a message fails to send, the app now surfaces clearer error messages with HTTP status codes.
  • Underlying HTTP errors are unified into a single, user-facing error while preserving response details for easier troubleshooting.
  • Reduces ambiguity around delivery failures, making it simpler to diagnose misconfiguration or endpoint issues. No impact on successful message delivery.

[linear]

APP-142 report customer issue for invalid teams webhook

[github-actions]

👋 @ofek1weiss
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

[coderabbitai]

Walkthrough

Introduces a new exception class TeamsWebhookHttpError and updates the Teams webhook messaging flow to catch requests HTTPError and re-raise it as TeamsWebhookHttpError with the original response attached.

Changes

Cohort / File(s)	Summary
Teams Webhook Error Handling elementary/messages/messaging_integrations/teams_webhook.py	Added public exception TeamsWebhookHttpError (wraps requests.Response, exposes status_code and response). Updated send flow to catch requests.HTTPError and raise TeamsWebhookHttpError with preserved exception chaining.

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant TeamsWebhook as TeamsWebhook
  participant Requests as requests
  participant Teams as Microsoft Teams

  Client->>TeamsWebhook: send(message)
  TeamsWebhook->>Requests: POST webhook_url with payload
  Requests->>Teams: HTTP POST
  alt Success
    Teams-->>Requests: 2xx response
    Requests-->>TeamsWebhook: Response
    TeamsWebhook-->>Client: return
  else HTTP error
    Teams-->>Requests: 4xx/5xx response
    Requests-->>TeamsWebhook: raise HTTPError (with Response)
    TeamsWebhook-->>Client: raise TeamsWebhookHttpError (wraps Response)
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I thump my paws on tidy logs, hooray!
We catch the storms the web may spray.
If Teams blows gales of 4xx skies,
I wrap the gusts with clearer cries.
A hop, a try, exceptions tamed—
Now errors come neatly named. 🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly highlights the addition of a more detailed exception for Teams webhook failures, reflecting the main change in the pull request. It is concise, specific, and avoids unnecessary detail, making it understandable at a glance by teammates scanning history.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch app-142-report-more-detailed-teams-webhook

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8c8c8b2 and 41c3459.

📒 Files selected for processing (1)

• elementary/messages/messaging_integrations/teams_webhook.py (2 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

elementary/messages/messaging_integrations/teams_webhook.py (1)

elementary/messages/messaging_integrations/exceptions.py (1)

• MessagingIntegrationError (1-2)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: test / test
• GitHub Check: code-quality

🔇 Additional comments (2)

elementary/messages/messaging_integrations/teams_webhook.py (2)

30-37: LGTM! Well-structured exception class.

The implementation correctly wraps the requests.Response object and provides clear error messaging. Storing both the status_code and full response gives callers flexibility for error handling and debugging.

---

100-101: LGTM! Exception handling correctly preserves error context.

The implementation properly catches HTTP errors (4xx/5xx) from raise_for_status() and wraps them with additional context while preserving the exception chain using from e. The catch order is correct since HTTPError is a subclass of RequestException.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}