Skip to content

Conversation

@haritamar
Copy link
Collaborator

@haritamar haritamar commented Jan 1, 2026

null

Summary by CodeRabbit

  • Chores
    • Updated dbt package configuration to replace the published data reliability package with a git-based source and pinned revision.
    • Removed the previous published package entry and added the git-sourced dependency to ensure the project uses the specified revision of the data reliability tooling.

✏️ Tip: You can customize this high-level summary in your review settings.

@linear
Copy link

linear bot commented Jan 1, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

👋 @haritamar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@coderabbitai
Copy link

coderabbitai bot commented Jan 1, 2026

📝 Walkthrough

Walkthrough

Swaps the elementary dbt package source from the published elementary-data/elementary v0.21.0 to a git-based dependency pointing to https://github.com/elementary-data/dbt-data-reliability.git at revision f5c062d8ec0f12796ec36685d4d514126aa9c3c9, and updates the package-lock entry sha1 to a86176fbc2db613395147d1bc40ce115cae2b5a5.

Changes

Cohort / File(s) Summary
dbt package manifests
elementary/monitor/dbt_project/packages.yml, elementary/monitor/dbt_project/package-lock.yml
Removed package: elementary-data/elementary version: 0.21.0; added git dependency https://github.com/elementary-data/dbt-data-reliability.git with revision: f5c062d8ec0f12796ec36685d4d514126aa9c3c9; updated lockfile entry sha1 to a86176fbc2db613395147d1bc40ce115cae2b5a5.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • using elementary 0.19.0 #1942: Modifies the same dbt package entries in packages.yml / package-lock.yml and concerns switching package source/version.

Suggested reviewers

  • ofek1weiss

Poem

🐰🌿 I hopped from tag to commit with glee,
Swapped a package path beneath a tree,
Locks updated, hashes snug and neat,
A tiny change — but oh, how sweet!

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the dbt package reference from a published version to a git-based dependency.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b5c4bc2 and 5fa4e25.

📒 Files selected for processing (2)
  • elementary/monitor/dbt_project/package-lock.yml
  • elementary/monitor/dbt_project/packages.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • elementary/monitor/dbt_project/package-lock.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test / test
  • GitHub Check: code-quality
🔇 Additional comments (1)
elementary/monitor/dbt_project/packages.yml (1)

4-5: The commit hash is valid and is from the master branch.

The revision f5c062d8ec0f12796ec36685d4d514126aa9c3c9 exists in the dbt-data-reliability repository and is the current HEAD of master. Remember to revert this git-based dependency back to a published package version (per the guidance in lines 11-13) when releasing a new CLI version.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
elementary/monitor/dbt_project/packages.yml (1)

4-5: Consider adding a comment explaining the specific commit.

The git-based dependency change aligns with the pattern for unreleased versions noted in the comments below. However, consider adding a brief inline comment explaining why this specific commit is needed (e.g., referencing the ELE-5191 fix mentioned in the PR title) to help future maintainers understand the temporary nature of this dependency.

🔎 Suggested enhancement with explanatory comment
+ # Using commit with fix for ELE-5191 (test_result_rows logic update)
  - git: https://github.com/elementary-data/dbt-data-reliability.git
    revision: 96f29dce3711f38c63f992bcaf8848b101d63194
📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3624b8b and b5c4bc2.

📒 Files selected for processing (2)
  • elementary/monitor/dbt_project/package-lock.yml
  • elementary/monitor/dbt_project/packages.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test / test
  • GitHub Check: code-quality
🔇 Additional comments (2)
elementary/monitor/dbt_project/package-lock.yml (1)

4-6: Lock file correctly reflects the git-based dependency.

The lock file change appropriately switches from a published package to a git-based dependency. The specified commit revision is valid and accessible in the repository, with the commit message "update dbt package reference" aligning with the intended change.

elementary/monitor/dbt_project/packages.yml (1)

4-5: Git commit is valid and accessible.

The commit 96f29dce3711f38c63f992bcaf8848b101d63194 exists and contains the expected test_result_rows changes:

  • Commit message: "test_result_rows: add row_index and test_type"
  • Modified files include models/edr/run_results/test_result_rows.sql and related test handling logic

- package: elementary-data/elementary
version: 0.21.0
- git: https://github.com/elementary-data/dbt-data-reliability.git
revision: 96f29dce3711f38c63f992bcaf8848b101d63194
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to update to the hash from master after it is merged

@haritamar haritamar merged commit 36a74db into master Jan 6, 2026
6 checks passed
@haritamar haritamar deleted the ele-5191-fix-for-the-logic-updating-test_result_rows branch January 6, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants