Skip to content

fix: add ClickHouse-specific UPDATE syntax for alert status updates #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add ClickHouse-specific UPDATE syntax for alert status updates #2090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 25 additions & 9 deletions elementary/monitor/dbt_project/macros/alerts/manage/update_sent_alerts.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,32 @@
{% macro update_sent_alerts(alert_ids, sent_at) %}
{% if execute %}
{% if alert_ids %}
{% set update_sent_alerts_query %}
update {{ ref('elementary_cli', 'alerts_v2') }}
set status = 'sent',
sent_at = {{ elementary.edr_cast_as_timestamp(elementary.edr_quote(sent_at)) }},
updated_at = {{ elementary.edr_current_timestamp() }}
where alert_id in {{ elementary.strings_list_to_tuple(alert_ids) }}
and status = 'pending'
and {{ elementary.edr_cast_as_timestamp('detected_at') }} >= {{ elementary_cli.get_alerts_time_limit() }}
{% endset %}
{% set update_sent_alerts_query = elementary_cli.get_update_sent_alerts_query(alert_ids, sent_at) %}
{% do elementary.run_query(update_sent_alerts_query) %}
{% endif %}
{% endif %}
{% endmacro %}

{% macro get_update_sent_alerts_query(alert_ids, sent_at) %}
{% do return(adapter.dispatch("get_update_sent_alerts_query", "elementary_cli")(alert_ids, sent_at)) %}
{% endmacro %}

{% macro default__get_update_sent_alerts_query(alert_ids, sent_at) %}
update {{ ref('elementary_cli', 'alerts_v2') }}
set status = 'sent',
sent_at = {{ elementary.edr_cast_as_timestamp(elementary.edr_quote(sent_at)) }},
updated_at = {{ elementary.edr_current_timestamp() }}
where alert_id in {{ elementary.strings_list_to_tuple(alert_ids) }}
and status = 'pending'
and {{ elementary.edr_cast_as_timestamp('detected_at') }} >= {{ elementary_cli.get_alerts_time_limit() }}
{% endmacro %}

{% macro clickhouse__get_update_sent_alerts_query(alert_ids, sent_at) %}
ALTER TABLE {{ ref('elementary_cli', 'alerts_v2') }}
UPDATE status = 'sent',
sent_at = {{ elementary.edr_cast_as_timestamp(elementary.edr_quote(sent_at)) }},
updated_at = {{ elementary.edr_current_timestamp() }}
WHERE alert_id in {{ elementary.strings_list_to_tuple(alert_ids) }}
and status = 'pending'
and {{ elementary.edr_cast_as_timestamp('detected_at') }} >= {{ elementary_cli.get_alerts_time_limit() }}
{% endmacro %}
24 changes: 18 additions & 6 deletions elementary/monitor/dbt_project/macros/alerts/manage/update_skipped_alerts.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,24 @@
{% macro update_skipped_alerts(alert_ids) %}
{% if execute %}
{% if alert_ids %}
{% set update_skipped_alerts_query %}
UPDATE {{ ref('elementary_cli', 'alerts_v2') }} set status = 'skipped', updated_at = {{ elementary.edr_current_timestamp() }}
WHERE alert_id IN {{ elementary.strings_list_to_tuple(alert_ids) }} and status = 'pending' and
{{ elementary.edr_cast_as_timestamp('detected_at') }} >= {{ elementary_cli.get_alerts_time_limit() }}
{% endset %}
{% set update_skipped_alerts_query = elementary_cli.get_update_skipped_alerts_query(alert_ids) %}
{% do elementary.run_query(update_skipped_alerts_query) %}
{% endif %}
{% endif %}
{% endmacro %}
{% endmacro %}

{% macro get_update_skipped_alerts_query(alert_ids) %}
{% do return(adapter.dispatch("get_update_skipped_alerts_query", "elementary_cli")(alert_ids)) %}
{% endmacro %}

{% macro default__get_update_skipped_alerts_query(alert_ids) %}
UPDATE {{ ref('elementary_cli', 'alerts_v2') }} set status = 'skipped', updated_at = {{ elementary.edr_current_timestamp() }}
WHERE alert_id IN {{ elementary.strings_list_to_tuple(alert_ids) }} and status = 'pending' and
{{ elementary.edr_cast_as_timestamp('detected_at') }} >= {{ elementary_cli.get_alerts_time_limit() }}
{% endmacro %}

{% macro clickhouse__get_update_skipped_alerts_query(alert_ids) %}
ALTER TABLE {{ ref('elementary_cli', 'alerts_v2') }} UPDATE status = 'skipped', updated_at = {{ elementary.edr_current_timestamp() }}
WHERE alert_id IN {{ elementary.strings_list_to_tuple(alert_ids) }} and status = 'pending' and
{{ elementary.edr_cast_as_timestamp('detected_at') }} >= {{ elementary_cli.get_alerts_time_limit() }}
{% endmacro %}
Loading