Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem\n\nThe
historical_ordersmodel outputs all monetary columns (amount,credit_card_amount,coupon_amount,bank_transfer_amount,gift_card_amount) in cents, whilereal_time_ordersalready converts them to dollars using thecents_to_dollarsmacro.\n\nSince theordersmodel unions both tables, this creates a 100× scale mismatch in theamountcolumn, which propagates through:\norders→customer_conversions→attribution_touches→cpa_and_roas\n\nThis causes theRETURN_ON_ADVERTISING_SPENDanomaly test to fail continuously (incident with 71+ failure events since Oct 2025).\n\n## Fix\n\n-historical_orders.sql: Applycents_to_dollars()macro to all monetary columns, matching the pattern inreal_time_orders.\n-real_time_orders.sql: Add a clarifying comment (no logic changes).\n\n## Related\n\n- Incident: column_anomalies - Average oncpa_and_roas.RETURN_ON_ADVERTISING_SPEND(HIGH severity)\n- JIRA: JSO-1"Created by:
joost@elementary-data.com