Conversation
historical_orders.amount was still in cents while real_time_orders.amount was already converted to dollars via cents_to_dollars(). This caused a ~100x inflation in revenue flowing into cpa_and_roas, triggering the ROAS anomaly detection test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
historical_ordersmodel outputs monetary amounts (amount,credit_card_amount, etc.) in cents, whilereal_time_ordersconverts them to dollars using thecents_to_dollars()macro. When these areUNION ALL'd in theordersmodel, the mixed units cause a ~100× inflation in revenue that propagates through:orders→customer_conversions→attribution_touches→cpa_and_roasThis is the root cause of the persistent RETURN_ON_ADVERTISING_SPEND anomaly incident (HIGH severity, ongoing since Oct 2025).
Fix
historical_orders.sql: Applycents_to_dollars()to all monetary columns, matchingreal_time_orders.real_time_orders.sql: Add clarifying comment (no logic change).Impact
Once merged and rebuilt, the ROAS metric in
cpa_and_roaswill return to normal values and the anomaly incident should resolve.Created by:
maayan+172@elementary-data.com