Conversation
historical_orders.amount was in cents while real_time_orders.amount was in dollars, causing a 100x mismatch in the UNION ALL inside orders. This propagated up to cpa_and_roas.return_on_advertising_spend, triggering the column_anomalies test. Apply the cents_to_dollars() macro to all monetary columns in historical_orders to match real_time_orders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
historical_ordersmodel outputs monetary amounts in cents whilereal_time_ordersoutputs them in dollars. Both are unioned in theordersmodel, causing a 100× mismatch that propagates through:orders→customer_conversions→attribution_touches→cpa_and_roasThis triggered the column_anomalies (average) test on
RETURN_ON_ADVERTISING_SPEND— incident JSO-1.Fix
historical_orders.sql: Apply thecents_to_dollars()macro to all monetary columns (amount,credit_card_amount,coupon_amount,bank_transfer_amount,gift_card_amount), matching the pattern already used inreal_time_orders.sql.real_time_orders.sql: Add a clarifying comment noting amounts are in dollars (no logic change).Validation
After merging, the
column_anomaliestest oncpa_and_roas.RETURN_ON_ADVERTISING_SPENDshould return to normal within one detection period.Created by:
maayan+172@elementary-data.com