Conversation
historical_orders.amount was in cents while real_time_orders.amount was already in dollars. This mismatch caused a ~100x inflation in the ROAS metric in cpa_and_roas, triggering anomaly detection failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
historical_ordersmodel was outputting monetary amounts in cents, whilereal_time_orderswas already converting to dollars using thecents_to_dollars()macro. Since theordersmodel unions both viaUNION ALL, this created a unit mismatch in theamountcolumn.This propagated through
customer_conversions→attribution_touches→cpa_and_roas, inflating the RETURN_ON_ADVERTISING_SPEND metric by ~100x and triggering ongoing anomaly detection failures (74 consecutive failures since Oct 2025).Fix
historical_orders.sql: Applycents_to_dollars()to all monetary columns, matching the existing pattern inreal_time_orders.sql.real_time_orders.sql: Added clarifying comment — no logic changes.Related Incident
cpa_and_roas.RETURN_ON_ADVERTISING_SPENDCreated by:
maayan+172@elementary-data.com