Maayan via Elementary: feat: Add test coverage for cpa_and_roas (JSO-40)#903
Open
Maayan via Elementary: feat: Add test coverage for cpa_and_roas (JSO-40)#903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSO-40: Test coverage on cpa_and_roas
This PR enforces a data contract on the
cpa_and_roastable with the following tests:Freshness
dbt_utils.recencyondaycolumn – ensures data is updated up until yesterdayCompleteness (no empty values)
not_nullon all 7 columns:day,utm_source,attribution_points,attribution_revenue,total_spend,cost_per_acquisition,return_on_advertising_spendUniqueness (no duplications)
dbt_utils.unique_combination_of_columnson (day,utm_source) – validates the natural grain of the tableAnomaly detection on key business KPIs
elementary.column_anomaliesoncost_per_acquisition(average)elementary.column_anomaliesonattribution_revenue(average)All new tests are set to severity warning.
Resolves: JSO-40
Created by:
maayan+172@elementary-data.com