Conversation
historical_orders.amount was stored in cents while real_time_orders.amount was already in dollars. Since both models are UNIONed in the orders model, this caused a ~100x inflation in revenue for historical data, which propagated through customer_conversions → attribution_touches → cpa_and_roas, triggering the ROAS anomaly detection test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
historical_ordersmodel was exposing monetary amounts in cents whilereal_time_ordersalready converts them to dollars using thecents_to_dollars()macro. Since both models are combined viaUNION ALLin theordersmodel, this unit mismatch caused:customer_conversions→attribution_touches→cpa_and_roasRETURN_ON_ADVERTISING_SPENDcolumn (74 failure events since Oct 2025)Fix
historical_orders.sql: Applycents_to_dollars()macro to all monetary columns (amount, credit_card_amount, coupon_amount, bank_transfer_amount, gift_card_amount)real_time_orders.sql: Added clarifying comment (no logic changes)Impact
This resolves incident
2924da99-a790-4dcb-b92a-5f9571d1fdce(HIGH severity, ACKNOWLEDGED) on the criticalcpa_and_roasmodel owned by @Finance-team.Created by:
maayan+172@elementary-data.com