Maayan via Elementary: Optimize agg_sessions: explicit columns & incremental filter#906
Open
Maayan via Elementary: Optimize agg_sessions: explicit columns & incremental filter#906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nThis PR optimizes the
agg_sessionsincremental model with two key changes:\n\n### Changes\n\n1. ReplacedSELECT *with explicit column selection — Only the 6 required columns (session_id,customer_id,ad_id,started_at,ended_at,utm_source) are now selected, reducing I/O and protecting against upstream schema changes.\n\n2. Added{% if is_incremental() %}filter — On incremental runs, only new sessions (based onstarted_at) are processed instead of full-scanning both source tables. This should significantly reduce execution time from the current ~186s.\n\n### Impact\n- Reduced warehouse I/O costs\n- Faster incremental runs\n- More resilient to upstream schema changesCreated by:
maayan+172@elementary-data.com