Skip to content

MainWindow: use get_components_by_extends #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 2 commits into from
Nov 17, 2025
Merged

MainWindow: use get_components_by_extends #125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02136b4
MainWindow: use get_components_by_extends
danirabbit Nov 17, 2025
d468e6d
Remove unused extension icon function
danirabbit Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 17 additions & 31 deletions src/MainWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,30 +167,26 @@ public class Feedback.MainWindow : Gtk.ApplicationWindow {
placeholder_stack.visible_child = placeholder;
});

appstream_pool.get_components_by_id ("io.elementary.settings").as_array ().foreach ((component) => {
component.get_addons ().foreach ((addon) => {
var repo_row = new RepoRow (
addon.name,
get_extension_icon_from_appstream (addon.get_icons ()),
Category.SETTINGS,
addon.get_url (AppStream.UrlKind.BUGTRACKER)
);

listbox.append (repo_row);
});
appstream_pool.get_components_by_extends ("io.elementary.settings").as_array ().foreach ((component) => {
var repo_row = new RepoRow (
component.name,
icon_from_appstream_component (component),
Category.SETTINGS,
component.get_url (AppStream.UrlKind.BUGTRACKER)
);

listbox.append (repo_row);
});

appstream_pool.get_components_by_id ("io.elementary.wingpanel").as_array ().foreach ((component) => {
component.get_addons ().foreach ((addon) => {
var repo_row = new RepoRow (
addon.name,
get_extension_icon_from_appstream (addon.get_icons ()),
Category.PANEL,
addon.get_url (AppStream.UrlKind.BUGTRACKER)
);
appstream_pool.get_components_by_extends ("io.elementary.wingpanel").as_array ().foreach ((component) => {
var repo_row = new RepoRow (
component.name,
icon_from_appstream_component (component),
Category.PANEL,
component.get_url (AppStream.UrlKind.BUGTRACKER)
);

listbox.append (repo_row);
});
listbox.append (repo_row);
});
} catch (Error e) {
critical (e.message);
Expand Down Expand Up @@ -367,16 +363,6 @@ public class Feedback.MainWindow : Gtk.ApplicationWindow {
return components;
}

private Icon get_extension_icon_from_appstream (GLib.GenericArray<AppStream.Icon> appstream_icons) {
foreach (unowned AppStream.Icon appstream_icon in appstream_icons) {
if (appstream_icon.get_kind () == AppStream.IconKind.STOCK) {
return new ThemedIcon (appstream_icon.get_name ());
}
}

return new ThemedIcon ("extension");
}

private Icon icon_from_appstream_component (AppStream.Component component) {
var as_icons = component.get_icons ();
Icon icon;
Expand Down