Skip to content

Replace Gdk.pixbuf_from_surface #2732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lenemter merged 5 commits into from
Feb 6, 2026
+35 −2
Merged

Replace Gdk.pixbuf_from_surface #2732

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b6ac1cd
Replace Gdk.pixbuf_from_surface
lenemter Jan 21, 2026
898f083
Fix lint
lenemter Jan 21, 2026
017f6d4
Merge branch 'main' into lenemter/replace-gdk-pixbuf-get-from-surface
lenemter Jan 26, 2026
2719a65
Merge branch 'main' into lenemter/replace-gdk-pixbuf-get-from-surface
lenemter Jan 29, 2026
a29385f
Merge branch 'main' into lenemter/replace-gdk-pixbuf-get-from-surface
lenemter Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions src/ScreenshotManager.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@ public class Gala.ScreenshotManager : Object {
}

try {
var screenshot = Gdk.pixbuf_get_from_surface (image, 0, 0, image.get_width (), image.get_height ());
var screenshot = pixbuf_from_surface (image);
var file = File.new_for_path (used_filename);
FileIOStream stream;
if (file.query_exists ()) {
Expand All @@ -525,7 +525,7 @@ public class Gala.ScreenshotManager : Object {
private bool save_image_to_clipboard (Cairo.ImageSurface image, string filename, out string used_filename) {
used_filename = filename;

var screenshot = Gdk.pixbuf_get_from_surface (image, 0, 0, image.get_width (), image.get_height ());
var screenshot = pixbuf_from_surface (image);
if (screenshot == null) {
warning ("Could not save screenshot to clipboard: null pixbuf");
return false;
Expand Down Expand Up @@ -634,4 +634,37 @@ public class Gala.ScreenshotManager : Object {
wm.stage.queue_redraw ();
yield;
}

private static Gdk.Pixbuf pixbuf_from_surface (Cairo.ImageSurface image) {
var width = image.get_width ();
var height = image.get_height ();

var pixbuf = new Gdk.Pixbuf (RGB, true, 8, width, height);

unowned var src_data = image.get_data ();
unowned var dest_data = pixbuf.get_pixels ();

for (var y = 0; y < height; y++) {
var row_start = y * width * 4;

for (var x = 0; x < width; x++) {
var pixel_start = row_start + x * 4;
var alpha = src_data[pixel_start + 3];

if (alpha == 0) {
dest_data[pixel_start + 0] = 0;
dest_data[pixel_start + 1] = 0;
dest_data[pixel_start + 2] = 0;
} else {
dest_data[pixel_start + 0] = (src_data[pixel_start + 2] * 255 + alpha / 2) / alpha;
dest_data[pixel_start + 1] = (src_data[pixel_start + 1] * 255 + alpha / 2) / alpha;
dest_data[pixel_start + 2] = (src_data[pixel_start + 0] * 255 + alpha / 2) / alpha;
}

dest_data[pixel_start + 3] = alpha;
}
}

return pixbuf;
}
}