Conversation
leolost2605
approved these changes
Jan 22, 2026
Member
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
Yeah I don't love it either but LGTM
Member
|
Hmm one thing though: Might there be cases where a window might not know it's size (or for some reason doesn't provide it) at the beginning and spawn with 1x1 and then resize to the proper size? Because get_window_is_normal isn't really expected to return something different for the same window so this would lead to a bunch of problems... |
leolost2605
requested changes
Jan 24, 2026
Member
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
Actually I think we shouldn't do this. The main problem described in #2724 is that the dock doesn't hide again which is a bug that I've also seen happen and we should fix that instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2724
Not the best solution, but I couldn't find anything better