Conversation
lenemter
force-pushed
the
lenemter/rework-modal-actions
branch
5 times, most recently
from
dd04001 to
f2441c7
Compare
leolost2605
requested changes
Jan 24, 2026
Member
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
Looks good to me, great cleanup, just two comments :)
lenemter
force-pushed
the
lenemter/rework-modal-actions
branch
from
f2441c7 to
d469bfd
Compare
lenemter
force-pushed
the
lenemter/rework-modal-actions
branch
from
8cf10fa to
4e20ccc
Compare
leolost2605
approved these changes
Jan 27, 2026
Member
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
Minor comment apart from that LGTM!
lenemter
added a commit
that referenced
this pull request
Jan 28, 2026
ScreenshotManager: simplify composite_stage_cursor (#2740) Add cursor to the `image` directly instead of copying `image` to `target` and then adding cursor Don't handle window menus for windows that are not normal (#2736) Addresses #2723 Rework modal actions (#2739) We currently have duplicate keybinding filters across multiple components. This PR removes keybinding filter capabilities from modal proxies and instead introduces ModalActions flags. Then WindowManager filters keybindings based on these flags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have duplicate keybinding filters across multiple components. This PR removes keybinding filter capabilities from modal proxies and instead introduces ModalActions flags. Then WindowManager filters keybindings based on these flags