Open
Conversation
leolost2605
requested changes
Feb 7, 2026
| @@ -1766,7 +1757,7 @@ namespace Gala { | |||
|
|
|||
| #if !HAS_MUTTER48 | |||
| public override unowned Meta.PluginInfo? plugin_info () { | |||
Member
There was a problem hiding this comment.
Can we remove the whole method then?
| public Meta.Display display { private get; construct; } | ||
|
|
||
| private ComputeShouldHideOnWorkspace? compute_func = null; | ||
| private unowned ComputeShouldHideOnWorkspace? compute_func = null; |
Member
There was a problem hiding this comment.
This (and btw on main too) can lead to crashes if you're not careful so at least a documentation somewhere, probably for the constructor, would be great. Usually we should make it owned in the constructor and then transfer the ownership to this field but that would introduce a memory leak with the way we currently use it. The best thing would of course be if we could make it [CCode (has_target = false)] but we currently use an instance field in the func (but maybe we can drop that?) :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.