MultitaskingView: Fix occassions where the active workspace could be wrong#2787
Open
leolost2605 wants to merge 2 commits intomainfrom
Open
MultitaskingView: Fix occassions where the active workspace could be wrong#2787leolost2605 wants to merge 2 commits intomainfrom
leolost2605 wants to merge 2 commits intomainfrom
Conversation
leolost2605
force-pushed
the
leolost/mtv-fix-ws-desyncs
branch
from
95bac3b to
b88e092
Compare
leolost2605
force-pushed
the
leolost/mtv-fix-ws-desyncs
branch
from
b88e092 to
3bf05bc
Compare
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2701
I've introduced a jump method for the gesturecontroller here which also makes sure we send a commit and reset any running timeline whereas setting the progress wouldn't do that. I eventually want to make progress private set and move to this new method because having wrong commits is not really great but I'd leave that to a future PR.
I've also fixed goto comparing progress == to which could be the case - even if we won't stay at that
to- when a goto was called before but the timeline hasn't started yet. This would cause an early return even though the second goto should overwrite the first.